After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622310 - There are no icons on the button "Pause", "Continue", "Results"
There are no icons on the button "Pause", "Continue", "Results"
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.30.x
Other Linux
: Normal normal
: gnome-3-0
Assigned To: gnome-games-general-maint
GNOME Games maintainers
: 631668 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-21 18:23 UTC by vadik
Modified: 2011-04-07 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix missing icons (1.63 KB, patch)
2011-01-23 02:32 UTC, Emilio Pozuelo Monfort 		accepted-commit_now Details | Review

Description vadik 2010-06-21 18:23:01 UTC 
There are no icons on the button "Pause", "Continue", "Results"
Instead of icons sheets with cross.
Bug also present in other games package gnome-games.
Bug does not depend on the installed icon themes.

Archlinux, gnome-games 2.30.1-1

Original (Russian):
Отсутствуют иконки на кнопках "Пауза", "Продолжить", "Результаты".
Вместо иконок листки с крестиком.
Баг присутствует и в других играх пакета gnome-games.
Баг не зависит от установленной темы иконок.
Comment 1 Josselin Mouette 2010-07-03 15:02:44 UTC 
libgames-support references "stock_timer", "stock_timer_stopped", and "stock_scores", none of which still exist in gnome-icon-theme.
Comment 2 Emilio Pozuelo Monfort 2011-01-23 02:32:44 UTC 
Created attachment 179064 [details] [review]
Fix missing icons

Patch from Josselin Mouette to fix this bug.
Comment 3 Emilio Pozuelo Monfort 2011-01-23 02:34:05 UTC 
*** Bug 631668 has been marked as a duplicate of this bug. ***
Comment 4 Jason Clinton 2011-01-24 20:49:23 UTC 
Comment on attachment 179064 [details] [review]
Fix missing icons

Looks good to me.
Comment 5 Emilio Pozuelo Monfort 2011-01-24 21:30:11 UTC 
Thanks, pushed.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 Christian Persch 2011-01-30 13:25:06 UTC 
+    { GAMES_STOCK_RESUME_GAME,      GTK_STOCK_MEDIA_PLAY },
 #endif
 #ifndef HAVE_HILDON
     { GAMES_STOCK_NETWORK_GAME,     GTK_STOCK_NETWORK },
     { GAMES_STOCK_NETWORK_LEAVE,    GTK_STOCK_STOP },
     { GAMES_STOCK_PLAYER_LIST,      GTK_STOCK_INFO },
 
-    { GAMES_STOCK_PAUSE_GAME,       "stock_timer_stopped" },
-    { GAMES_STOCK_RESUME_GAME,      "stock_timer" },
-    { GAMES_STOCK_SCORES,           "stock_scores" },
+    { GAMES_STOCK_PAUSE_GAME,       GTK_STOCK_MEDIA_PAUSE },
 #endif /* !HAVE_HILDON */

Why did you add RESUME_GAME at the top, instead of inside the !HAVE_HILDON case where it was before? And it also needs to be ifdef'd inside stock_icon_aliases_bidi .
Comment 7 Christian Persch 2011-02-25 17:49:04 UTC 
Ping!
Comment 8 Christian Persch 2011-03-20 12:27:53 UTC 
Also,

+    { GAMES_STOCK_SCORES, "scores" },

where is this icon? It's installed as a 'private' icon, meaning that it should exist in our icons/ directory. But there is none.

Really, I should just revert this patch...
Comment 9 Christian Persch 2011-04-07 16:58:45 UTC 
This was fixed some time ago.