After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622292 - Load schemas from GSETTINGS_SCHEMA_DIR if set
Load schemas from GSETTINGS_SCHEMA_DIR if set
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
: 636166 644969 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-21 14:34 UTC by Milan Bouchet-Valat
Modified: 2015-02-22 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Load schemas from GSETTINGS_SCHEMA_DIR if set (1.55 KB, patch)
2010-06-21 14:34 UTC, Milan Bouchet-Valat
none Details | Review
Load-schemas-from-GSETTINGS_SCHEMA_DIR-if-set (1.49 KB, patch)
2010-06-21 16:10 UTC, Milan Bouchet-Valat
none Details | Review
editor: load schemas from the same sources as gsettings (1.11 KB, patch)
2011-01-19 21:45 UTC, Rui Matos
committed Details | Review

Description Milan Bouchet-Valat 2010-06-21 14:34:18 UTC
Created attachment 164220 [details] [review]
Load schemas from GSETTINGS_SCHEMA_DIR if set

See patch.

Note I'm not familiar with Vala, so I wanted to check:
if(schemas_dir)
but it didn't like that, so I checked for empty string. I guess the return value is translated to "" if NULL... ;-)
Comment 1 Milan Bouchet-Valat 2010-06-21 16:10:43 UTC
Created attachment 164228 [details] [review]
Load-schemas-from-GSETTINGS_SCHEMA_DIR-if-set

Lesson #1: Don't forget to rebuild your patch after you changed something... ;-)

This one is more correct.
Comment 2 Christian Persch 2011-01-07 19:25:12 UTC
gsettings itself looks in g_get_system_data_dirs() for the schemas, not /usr, so dconf-editor should too.
Comment 3 Milan Bouchet-Valat 2011-01-07 20:05:02 UTC
Yeah, probably a more logical solution. Feel free to update the patch, about half of the work is done... ;-)
Comment 4 Rui Matos 2011-01-19 21:45:46 UTC
Created attachment 178786 [details] [review]
editor: load schemas from the same sources as gsettings
Comment 5 Vincent Untz 2011-02-03 22:34:27 UTC
*** Bug 636166 has been marked as a duplicate of this bug. ***
Comment 6 Allison Karlitskaya (desrt) 2011-03-22 15:39:58 UTC
*** Bug 644969 has been marked as a duplicate of this bug. ***
Comment 7 Robert Ancell 2011-05-08 16:41:11 UTC
Comment on attachment 164228 [details] [review]
Load-schemas-from-GSETTINGS_SCHEMA_DIR-if-set

Obsolete by Rui's patch
Comment 8 Robert Ancell 2011-05-09 06:31:57 UTC
Review of attachment 178786 [details] [review]:

Comitted with minor changes
Comment 9 Robert Ancell 2011-05-09 06:33:28 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 André Klapper 2015-02-22 12:22:57 UTC
[moving dconf>editor tickets to dconf-editor product. See bug 744791]