After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622257 - Modernize autotools config
Modernize autotools config
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
0.4
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-21 03:50 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-06-21 14:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Modernize autotools config (2.10 KB, patch)
2010-06-21 04:02 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-06-21 03:50:28 UTC
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-06-21 04:02:14 UTC
Created attachment 164194 [details] [review]
Modernize autotools config

Use the new libtool syntax and store the macros in a m4 directory
Comment 2 Allison Karlitskaya (desrt) 2010-06-21 04:43:00 UTC
Comment on attachment 164194 [details] [review]
Modernize autotools config

looks yummy, i guess...  i hope it works. :)
Comment 3 Christian Persch 2010-06-21 12:51:55 UTC
+LT_PREREQ([2.2.6])

What's up with this high requirement? You seem to always use this, and I always have to downgrade it (intrepid only has 2.2.4), with no apparent ill effects. Shouldn't [2.2] be enough here?
Comment 4 Javier Jardón (IRC: jjardon) 2010-06-21 13:35:56 UTC
> +LT_PREREQ([2.2.6])
> 
> What's up with this high requirement? You seem to always use this, and I always
> have to downgrade it (intrepid only has 2.2.4), with no apparent ill effects.
> Shouldn't [2.2] be enough here?

Yeah, It's enough to use the new syntax.

But I use 2.2.6 as most current distros have 2.2.6 (At least Debian stable and supported fedoras). Feel free to change if you want.
Comment 5 André Klapper 2010-06-21 13:45:19 UTC
(In reply to comment #4)
> Yeah, It's enough to use the new syntax.
> But I use 2.2.6 as most current distros have 2.2.6

...which is no argument to unneededly raise the bar and exclude older distros if there is no advantage from it. Please use 2.2 only for future patches.
Comment 6 Allison Karlitskaya (desrt) 2010-06-21 14:18:34 UTC
Ok.  dropped it to 2.2.  Thanks for the feedback