GNOME Bugzilla – Bug 622246
Add key highlighting
Last modified: 2010-09-01 18:22:18 UTC
Some people can be interested on change the base color of the keyboard or even remark the key colors when the mouse is over them Implementation of a system to change these two colors and store the changes is needed
Created attachment 164180 [details] [review] Added schema entry for key colors
Created attachment 164181 [details] [review] UI changed on the preferences window for key color configuration
Created attachment 164182 [details] [review] Implementation for key color configuration
I am concerned that we might be adding too many options to the UI. I agree that there needs to be an option to override the color, but I am not sure if it should be in the UI. I am applying these to trunk anyway, but we will need to redesign the preferences UI in the future, IMHO.
Oops! It's only for mouse-over, I get it. Anyway, we need to think about how to keep the amount of preferences we will have in a sane UI. But that is another task..
Review of attachment 164182 [details] [review]: Please break lines that are longer than 80 characters. ::: caribou/ui/keyboard.py @@ +62,3 @@ layout_combo.connect("changed", self._on_layout_changed, client) + normal_color = gtk.gdk.Color(client.get_string(const.CARIBOU_GCONF + "/normal_color")) + normal_state_color_button = builder.get_object("normal_state_color_button") There should be a fallback here when no gconf key is set and no schema is installed. @@ +67,3 @@ + normal_state_color_button.set_color(normal_color) + normal_color = gtk.gdk.Color(client.get_string(const.CARIBOU_GCONF + "/normal_color")) + normal_state_color_button = builder.get_object("normal_state_color_button") ditto @@ +337,3 @@ + + self._update_colors() + def _colors_changed(self, client, connection_id, entry, args): ditto
Created attachment 164767 [details] [review] Fixed line width. Added default values for gconf settings
Merged in master. I think there should be a checkbox that makes these settings insensitive and make default/highlight conform with the GTK+ theme.
Created attachment 167976 [details] [review] Proper highlight colors.
The patch above adds a checkbox for using the default color theme.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.