GNOME Bugzilla – Bug 622181
[backup-restore] Backup settings uses unhelpful yes/no dialog
Last modified: 2010-07-29 06:49:30 UTC
In latest Ubuntu Lucid (YAY!) with Evolution 2.28.3 (2.28.3-0ubuntu9), if I go to backup my settings (File->Backup settings), I am presented with a File Save dialog (which is just fine), and then a dialog box warning me that I should close Evolution. This dialog, however, is an unfriendly and unhelpful yes/no dialog; further, the text of the dialog does not even make it clear which button to select to close Evolution. This dialog should probably have two buttons - one reading, "Cancel", and the other, "Close Evolution".
Relevant part of the HIG: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alerts-confirmation Lp bug report: https://bugs.launchpad.net/hundredpapercuts/+bug/572985
Okay, here is a patch which changes both the restore and backup dialogs. I have changed the backup dialog text from this: --- Evolution backup can start only when Evolution is not running. Please make sure that you save and close all your unsaved windows before proceeding. If you want Evolution to restart automatically after backup, please enable the toggle button. --- To this: --- To backup your data and settings, you must first close Evolution. Please make sure that you save any unsaved data before proceeding. --- I removed the unnecessary explanation about the togglebutton, it is not needed, it can explain itself. I also removed the bit about closing unsaved windows, this isn't what we want to tell the user, we want the user to saved any unsaved data, not just delete it. I also rephrased the first bit to make it orientated to what the user is doing, not speaking about the technical side of how it will work. I also changed the button text from: -- No | Yes -- To: -- Cancel | Close and Backup Evolution -- Now there is no confusion over what will happen. I have changed the restore dialog text from this: --- This will delete all your current Evolution data and settings and restore them from your backup. Evolution restore can start only when Evolution is not running. Please make sure that you close all your unsaved windows before you proceed. If you want Evolution to restart automatically restart after restore, please enable the toggle button. --- To this: --- To restore your data and settings, you must first close Evolution. Please make sure that you save any unsaved data before proceeding. This will delete all your current Evolution data and settings and restore them from your backup. --- this is the same text as in the backup dialog, but with the added sentence of warning the user of what will happen. Likewise the button text has been changed from: -- No | Yes -- To: -- Cancel | Close and Restore Evolution -- Can someone apply this patch to trunk?
Created attachment 166689 [details] [review] Patch to change the text on both dialogs
Created attachment 166690 [details] [review] Patch that works this time Sorry, made a mistake with the response IDs, here is a patch that works (a bit more useful!)
Excellent wording! Committed your patch for Evolution 2.31.6. http://git.gnome.org/browse/evolution/commit/?id=a73b369b72ec688c190a32952cd2d672d4eb1bf5
Thank you very much for the quick response and the kind words :)