After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622163 - Add font face change
Add font face change
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal enhancement
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-20 09:58 UTC by Daniel Baeyens
Modified: 2010-09-01 18:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GConf schema for default key font face and size (1.12 KB, patch)
2010-06-20 09:59 UTC, Daniel Baeyens
none Details | Review
It modifies glade file to reorganize the preferences window (18.57 KB, patch)
2010-06-20 09:59 UTC, Daniel Baeyens
none Details | Review
Code changes to modify default font (4.25 KB, patch)
2010-06-20 10:00 UTC, Daniel Baeyens
needs-work Details | Review
Loads font configuration when Caribou starts (1.36 KB, patch)
2010-06-20 17:40 UTC, Daniel Baeyens
none Details | Review
Fixes line width, adds default value for font name (2.58 KB, patch)
2010-06-27 12:47 UTC, Daniel Baeyens
none Details | Review
Allow user to change key font and size. (16.15 KB, patch)
2010-08-16 17:00 UTC, Eitan Isaacson
committed Details | Review

Description Daniel Baeyens 2010-06-20 09:58:07 UTC
Some people can be interested on changing the size/font face/style of the fonts in Caribou, separately to the ones selected for the desktop.

Add a way to select the desired font
Comment 1 Daniel Baeyens 2010-06-20 09:59:05 UTC
Created attachment 164114 [details] [review]
GConf schema for default key font face and size
Comment 2 Daniel Baeyens 2010-06-20 09:59:46 UTC
Created attachment 164115 [details] [review]
It modifies glade file to reorganize the preferences window
Comment 3 Daniel Baeyens 2010-06-20 10:00:14 UTC
Created attachment 164116 [details] [review]
Code changes to modify default font
Comment 4 Daniel Baeyens 2010-06-20 17:40:04 UTC
Created attachment 164150 [details] [review]
Loads font configuration when Caribou starts
Comment 5 Eitan Isaacson 2010-06-21 17:28:27 UTC
Review of attachment 164116 [details] [review]:

Please limit lines to 80 chars.

::: caribou/ui/keyboard.py
@@ +66,3 @@
         layout_combo.connect("changed", self._on_layout_changed, client)
+        key_font_widget.set_font_name(client.get_string(const.CARIBOU_GCONF + "/key_font"))
+        key_font_widget = builder.get_object("key_font_selector")

There should be a fallback when the gconf key is not present (and schema is not installed).
Comment 6 Daniel Baeyens 2010-06-27 12:47:59 UTC
Created attachment 164744 [details] [review]
Fixes line width, adds default value for font name
Comment 7 Eitan Isaacson 2010-07-12 17:50:53 UTC
OK,

Sorry for this being a bit late, but this is what I am thinking..

When adjusting the font size, the keys don't grow to fit the labels.
Maybe we should get rid of the "key size" option, and simply adjust the size depending on the font?

I would typically merge and release this, but I feel like this feature in itself is not useful unless you could enlarge the fonts, which this patch does not do well.
Comment 8 Eitan Isaacson 2010-08-16 17:00:59 UTC
Created attachment 167978 [details] [review]
Allow user to change key font and size.
Comment 9 Eitan Isaacson 2010-08-16 17:01:27 UTC
This is my attempt at doing this. Excuse the large patch.
Comment 10 Eitan Isaacson 2010-09-01 18:17:08 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.