GNOME Bugzilla – Bug 622069
greeter doesn't work when there's no local user
Last modified: 2010-06-22 02:45:12 UTC
This is https://bugzilla.novell.com/show_bug.cgi?id=615044 =============== my system is configured for NIS so doesn't have any local users besides root. The gdm greeter in this case only shows a lone 'login' button and the waiting curser but is empty otherwise. Ie there is no way to enter a user name. Pressing the login button leads to X restart. Simply adding one local user makes the button to manually enter a user name show up. =============== My guess is that commits 5f8723c4fccff6aed79edbe635e3e16fa74a42d1 and 6ef14933e32173235eaafb0bc9d7188accce3364 introduced this bug.
Created attachment 164268 [details] [review] Patch to show the input box when there's no local user Here's the patch I came to when fixing this. It seems to work good when testing here. (note: it's done against 2.30.2, I didn't check yet if it applies to gnome-2-30 or master)
Review of attachment 164268 [details] [review]: ::: gdm-2.30.2.orig/gui/simple-greeter/gdm-greeter-login-window.c @@ +911,3 @@ + if (user_chooser_has_no_user (login_window)) { + /* There's no face browser to show */ + login_window->priv->show_cancel_button = FALSE; We might want to move this to switch_mode(), in the MODE_AUTHENTICATION case. I didn't test it, but it probably makes sense.
Review of attachment 164268 [details] [review]: Looks good. I'm going to push it with the one change. ::: gdm-2.30.2.orig/gui/simple-greeter/gdm-chooser-widget.c @@ +1919,2 @@ } I think maybe this should go in gdm_chooser_widget_loaded instead.
Pushed. Thanks.