After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 622021 - Closed signal is not emitted when the screensaver si active
Closed signal is not emitted when the screensaver si active
Status: RESOLVED FIXED
Product: notification-daemon
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-06-18 17:59 UTC by chuchiperriman
Modified: 2010-06-24 04:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Send Close when notification isn't shown (2.22 KB, patch)
2010-06-24 01:32 UTC, Bastien Nocera
none Details | Review

Description chuchiperriman 2010-06-18 17:59:54 UTC
I'm connecting to closed signal to do some operations but if I have the screensaver active it is not emitted
Comment 1 chuchiperriman 2010-06-18 18:31:43 UTC
The problem is:

I show the notification (pynotify) but it is not shown because the screensaver is active then the closed signal is never emitted.

Perhaps libnotify should tell me that the notification cannot be shown...
Comment 2 Bastien Nocera 2010-06-24 01:31:07 UTC
libnotify has no concept of the screensaver being on or not.

All the "do not disturb" code lives in notification-daemon. There are multiple ways we could handle this:
- return an error from notify_notification_show(), but this would usually imply a severe failure
- send a close signal as soon as done dealing with the "Show" call

In any case, barring a change in the spec, this should be done in the notification-daemon.
Comment 3 Bastien Nocera 2010-06-24 01:32:39 UTC
Created attachment 164464 [details] [review]
Send Close when notification isn't shown

When a notification comes in and we have the screensaver or a
fullscreen application showing, we never actually show the
popup, and the application will not receive a "Close" notification.

Change this so that the close notification is the first thing
we send out after being done dealing with the requested notification.
Comment 4 Bastien Nocera 2010-06-24 01:37:10 UTC
Note that bug 608068 requests for the popups to be deferred, but that's not really possible without a change in the spec.
Comment 5 William Jon McCann 2010-06-24 04:32:18 UTC
Probably should keep track of that idle source but probably isn't a huge deal.  Pushed thanks.