After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621940 - CCShell API doesn't allow to get top-level
CCShell API doesn't allow to get top-level
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-17 22:10 UTC by Bastien Nocera
Modified: 2010-11-09 17:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a get_toplevel accessor (4.02 KB, patch)
2010-10-16 13:35 UTC, Gerd Kohlberger 		committed Details | Review

Description Bastien Nocera 2010-06-17 22:10:00 UTC 
The CCPanel and CCShell API don't allow getting the top-level window, which makes parenting error messages a bit complicated.

Something like cc_shell_get_top_level_window() would be good enough.
Comment 1 Bastien Nocera 2010-06-23 17:28:46 UTC 
This is needed for both gnome-bluetooth and gnome-media.
Comment 2 Gerd Kohlberger 2010-10-16 13:33:29 UTC 
It would also be useful to parent the "Options..." dialogs in the universal-access panel.
Comment 3 Gerd Kohlberger 2010-10-16 13:35:09 UTC 
Created attachment 172490 [details] [review]
Add a get_toplevel accessor
Comment 4 Bastien Nocera 2010-11-05 00:58:40 UTC 
Huh, I committed this, but I don't actually see how you're supposed to use it.
Comment 5 Gerd Kohlberger 2010-11-05 02:22:48 UTC 
(In reply to comment #4)
> Huh, I committed this, but I don't actually see how you're supposed to use it.

The idea was:
shell = cc_panel_get_shell (CC_PANEL (some_panel));
toplevel = cc_shell_get_toplevel (shell);
Comment 6 Bastien Nocera 2010-11-09 17:24:10 UTC 
I added a tiny bit of code to actually set the "shell" variable on the panel objects:
http://git.gnome.org/browse/gnome-control-center/commit/?id=5472040227a7a4feabf142827174e0a614e3e646

Thanks