After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621931 - support GType and GVariant types
support GType and GVariant types
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: 1.16
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-17 20:53 UTC by Christian Persch
Modified: 2010-06-19 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support GType and GVariant fundamental types (2.00 KB, patch)
2010-06-17 20:56 UTC, Christian Persch 		needs-work Details | Review
Support GType and GVariant types (1.96 KB, patch)
2010-06-18 16:15 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2010-06-17 20:53:40 UTC 
.
Comment 1 Christian Persch 2010-06-17 20:56:35 UTC 
Created attachment 163962 [details] [review]
Support GType and GVariant fundamental types

Bug #621931.
Comment 2 Matthias Clasen 2010-06-17 21:24:20 UTC 
Looks great to me.
Comment 3 Christian Persch 2010-06-17 22:28:32 UTC 
(Actually GType isn't fundamental, but the GParamSpecGType still needs to be handled.)
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-06-18 13:27:17 UTC 
Comment on attachment 163962 [details] [review]
Support GType and GVariant fundamental types

this causes the tests to fail:

tester-scan.c: In function ‘get_type_name’:
tester-scan.c:366: error: case label does not reduce to an integer constant
tester-scan.c: In function ‘describe_type’:
tester-scan.c:1173: error: too few arguments to function ‘get_type_name’


Seems that G_TYPE_GTYPE is not a fundamental type that can be checked in a case: statement.
Comment 5 Christian Persch 2010-06-18 16:15:04 UTC 
Created attachment 164021 [details] [review]
Support GType and GVariant types

"make check" now passes.

Bug #621931.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2010-06-19 09:52:42 UTC 
Thanks!

commit ab8cde85947c60b8d58cc9514703ceb1194a861f
Author: Christian Persch <chpe@gnome.org>
Date:   Thu Jun 17 22:54:36 2010 +0200

    scan: Support GType and GVariant types. Fixes #621931.
    
    Conditionaly handle new fundamental GTypes.