GNOME Bugzilla – Bug 621902
artifacts shown at the button of maximized terminal after minimizing another window over it
Last modified: 2010-09-29 08:27:43 UTC
Created attachment 163930 [details] 1.png I suffer this problem since upgrading from 2.28 to gnome-terminal-2.30.1. To reproduce, follow these steps: 1. Open a gnome-terminal 2. Maximize its window 3. Open a different app and also maximize it 4. Minimize last window -> You will see some artifacts appear the the button of maximized gnome-terminal window because of metacity minimize effect (see attached screenshot) Thanks for solving this
Fixed in vte master a couple days ago. We should make a stable release.
Could you please point me to the commit to backport it downstream? Thanks a lot :-D
The following three, in that order: 430dd34fa9532fa492ea512f226e8483d1393716 9370647823ce29c1088c351381a07a5506b74c84 405ed5bb3151940db0f21ff5b8e96bea94770f96
They work fine, thanks a lot :-D
(In reply to comment #3) > The following three, in that order: > > 430dd34fa9532fa492ea512f226e8483d1393716 > 9370647823ce29c1088c351381a07a5506b74c84 > 405ed5bb3151940db0f21ff5b8e96bea94770f96 They work fine with gnome-terminal, but we are seeing downstream that they cause problems to people running xfce's terminal: http://bugs.gentoo.org/show_bug.cgi?id=324631 (midnight-commander run from "terminal" causes X to consume 100% CPU) Do you think it's a vte or xfce's terminal problem? (that I could report to xfce upstream in that last case) Thanks again
It's hard to say, though it's hard to imagine these patches making any huge difference. Try applying just the two and report please.
(In reply to comment #3) > The following three, in that order: > > 430dd34fa9532fa492ea512f226e8483d1393716 > 9370647823ce29c1088c351381a07a5506b74c84 Once I apply the second patch, the problem appears Thanks :-) > 405ed5bb3151940db0f21ff5b8e96bea94770f96
We are currently only applying the other two patches since they fix original "artifacts" problems, but would be interesting to try to see what is wrong with commit 9370647823ce29c1088c351381a07a5506b74c84 since this could cause problems in future 0.26.0... if you want, I can open a separate bug report for that or, if you think it's a xfce terminal problem, I can open a bug for it Thanks
Fixed in master. Please test. In short, the 937064 commit was not needed given the other two in the series.
Humm, I committed 937064 again since it improves flicker. Please file a new bug if it still makes things very very slow.
Do you want that reverted revert also on vte-0-26 branch?
Not a huge deal, and given that there's one report that it slows things down considerably on some configurations, lets not have it until we figure out what's going on. Here is how to test the flicker: if you have your vte background set to white, try resizing gnome-terminal fast, the redraw areas will flicker to black then white without the patch, and don't flicker with the patch.
OK, I will take care as soon as I install vte-0.26.x Thanks :-)