After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621873 - Custom script for eclipse may be refactored
Custom script for eclipse may be refactored
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.30.x
Other All
: Normal normal
: 2.32.0
Assigned To: Jose Vilmar Estacio de Souza
Orca Maintainers
Depends on:
Blocks: 575776
 
 
Reported: 2010-06-17 11:19 UTC by Jose Vilmar Estacio de Souza
Modified: 2010-09-20 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revision 1 (4.52 KB, patch)
2010-06-17 12:29 UTC, Jose Vilmar Estacio de Souza 		none Details | Review
revision 2 (5.04 KB, patch)
2010-06-17 23:54 UTC, Jose Vilmar Estacio de Souza 		none Details | Review
revision 3 (4.94 KB, patch)
2010-06-18 18:13 UTC, Jose Vilmar Estacio de Souza 		committed Details | Review

Description Jose Vilmar Estacio de Souza 2010-06-17 11:19:13 UTC 
The logic used in the function _presentTextAtNewCaretPosition to determine whether the text should be spoken, can be optimized.
This requires that the functions onFocus, onTextInserted and onTextDeleted save the current position of the object when the text is spoken in this task .
This is already done so partially.
Comment 1 Jose Vilmar Estacio de Souza 2010-06-17 12:29:29 UTC 
Created attachment 163907 [details] [review]
Revision 1

Tested without problems
Comment 2 Jose Vilmar Estacio de Souza 2010-06-17 23:54:54 UTC 
Created attachment 163975 [details] [review]
revision 2

fix a situation where the line was read when user typing
Comment 3 Jose Vilmar Estacio de Souza 2010-06-18 18:13:20 UTC 
Created attachment 164030 [details] [review]
revision 3

I was using a logic to identify if caret was moved because user is typing. The logic was based in the difference between actual and previous position.
it is no longer necessary because an object:text-changed:insert is generated before and the character typed is processed in that function.
There is however an exception, when the object is a SINGLE_LINE.
This version of the patch tries to address this situation.

Needs to be reviewed.
Thanks.
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-06-19 16:40:24 UTC 
Review of attachment 164030 [details] [review]:

This certainly makes your script a lot cleaner. Nice! I'd be happy to push this to master if you do not have any other changes or require further testing. Please let me know. Thanks!
Comment 5 Jose Vilmar Estacio de Souza 2010-06-19 20:32:32 UTC 
No more changes.
Thanks.
Comment 7 Joanmarie Diggs (IRC: joanie) 2010-06-19 20:44:07 UTC 
(In reply to comment #5)
> No more changes.
> Thanks.

Awesome. Pushed to master. Thanks! Please feel free to close this bug out as FIXED if there's no additional work you need to do on it.