After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621872 - build failure: ev-media-player-keys.c:166: undefined reference to `g_bus_watch_proxy'
build failure: ev-media-player-keys.c:166: undefined reference to `g_bus_watc...
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 621884 (view as bug list)
Depends on:
Blocks: 621874
 
 
Reported: 2010-06-17 11:17 UTC by Craig Keogh
Modified: 2010-06-18 09:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
partially fix the build (2.90 KB, patch)
2010-06-17 14:18 UTC, Claudio Saavedra
none Details | Review
new patch (2.94 KB, patch)
2010-06-17 22:39 UTC, Claudio Saavedra
none Details | Review

Description Craig Keogh 2010-06-17 11:17:02 UTC
I am building git master on Fedora 13 via JHBuild. I am building against glib
git master. g_bus_watch_proxy, g_bus_unwatch_proxy have been removed from
glib's gio as per:
http://git.gnome.org/browse/glib/commit/?id=32f2e9a85beedeea36ac7623f68f6eb878465d44

build failure is:
------------------------
gcc -DHAVE_CONFIG_H -I. -I.. -DDATADIR=\"/opt/gnome2/share/evince\" -DGNOMEDATADIR=\"/opt/gnome2/share\" -I.. -I.. -I../cut-n-paste/zoom-control/ -I../cut-n-paste/toolbar-editor/ -I../cut-n-paste/totem-screensaver/ -I../cut-n-paste/gimpcellrenderertoggle/ -I../cut-n-paste/smclient/ -I../libdocument -I../libdocument -I../libview -I../libview -I../libmisc -I../properties -DGNOMEICONDIR=\""/opt/gnome2/share/pixmaps"\" -DBINDIR=\""/opt/gnome2/bin"\" -DLIBEXECDIR=\""/opt/gnome2/libexec"\" -DEVINCE_COMPILATION -pthread -I/opt/gnome2/include/libxml2 -I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/lib64/gtk-2.0/include -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/cairo -I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12   -I/opt/gnome2/include/gnome-keyring-1 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include   -DORBIT2=1 -pthread -I/opt/gnome2/include/gconf/2 -I/opt/gnome2/include/orbit-2.0 -I/opt/gnome2/include/dbus-1.0 -I/opt/gnome2/lib64/dbus-1.0/include -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include   -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE  -Wall -Wmissing-prototypes      -O0 -g -MT ev-media-player-keys.o -MD -MP -MF .deps/ev-media-player-keys.Tpo -c -o ev-media-player-keys.o ev-media-player-keys.c
mv -f .deps/ev-media-player-keys.Tpo .deps/ev-media-player-keys.Po
ev-media-player-keys.c: In function ‘ev_media_player_keys_init’:
ev-media-player-keys.c:166: warning: implicit declaration of function ‘g_bus_watch_proxy’
ev-media-player-keys.c: In function ‘ev_media_player_keys_finalize’:
ev-media-player-keys.c:193: warning: implicit declaration of function ‘g_bus_unwatch_proxy’
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -O0 -g   -L/opt/gnome2/lib64 -Wl,-rpath -Wl,/opt/gnome2/lib64 -o evince eggfindbar.o ev-application.o ev-file-monitor.o ev-history.o ev-keyring.o ev-marshal.o ev-message-area.o ev-metadata.o ev-navigation-action.o ev-navigation-action-widget.o ev-password-view.o ev-progress-message-area.o ev-properties-dialog.o ev-properties-fonts.o ev-properties-license.o ev-open-recent-action.o ev-utils.o ev-window.o ev-window-title.o ev-sidebar.o ev-sidebar-attachments.o ev-sidebar-layers.o ev-sidebar-links.o ev-sidebar-page.o ev-sidebar-thumbnails.o main.o ev-media-player-keys.o ../cut-n-paste/zoom-control/libephyzoom.la ../cut-n-paste/toolbar-editor/libtoolbareditor.la ../cut-n-paste/totem-screensaver/libtotemscrsaver.la ../cut-n-paste/gimpcellrenderertoggle/libgimpcellrenderertoggle.la ../cut-n-paste/smclient/libsmclient.la ../properties/libevproperties.la ../libdocument/libevdocument.la ../libview/libevview.la ../libmisc/libevmisc.la -pthread -L/opt/gnome2/lib64 -lxml2 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lpangoft2-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0 -lX11   -L/opt/gnome2/lib64 -lgnome-keyring -lglib-2.0   -L/opt/gnome2/lib64 -lgconf-2 -lglib-2.0   -lz -lm  
libtool: link: gcc -O0 -g -Wl,-rpath -Wl,/opt/gnome2/lib64 -o .libs/evince eggfindbar.o ev-application.o ev-file-monitor.o ev-history.o ev-keyring.o ev-marshal.o ev-message-area.o ev-metadata.o ev-navigation-action.o ev-navigation-action-widget.o ev-password-view.o ev-progress-message-area.o ev-properties-dialog.o ev-properties-fonts.o ev-properties-license.o ev-open-recent-action.o ev-utils.o ev-window.o ev-window-title.o ev-sidebar.o ev-sidebar-attachments.o ev-sidebar-layers.o ev-sidebar-links.o ev-sidebar-page.o ev-sidebar-thumbnails.o main.o ev-media-player-keys.o -pthread  -L/opt/gnome2/lib64 ../cut-n-paste/zoom-control/.libs/libephyzoom.a ../cut-n-paste/toolbar-editor/.libs/libtoolbareditor.a ../cut-n-paste/totem-screensaver/.libs/libtotemscrsaver.a ../cut-n-paste/gimpcellrenderertoggle/.libs/libgimpcellrenderertoggle.a ../cut-n-paste/smclient/.libs/libsmclient.a -lSM -lICE ../properties/.libs/libevproperties.a ../libdocument/.libs/libevdocument.so ../libview/.libs/libevview.so ../libmisc/.libs/libevmisc.a /home/oxyde/gnome2/evince/libview/.libs/libevview.so /home/oxyde/gnome2/evince/libdocument/.libs/libevdocument.so /opt/gnome2/lib64/libxml2.so /opt/gnome2/lib64/libgtk-x11-2.0.so /opt/gnome2/lib64/libgdk-x11-2.0.so /opt/gnome2/lib64/libatk-1.0.so /opt/gnome2/lib64/libgdk_pixbuf-2.0.so /opt/gnome2/lib64/libpangocairo-1.0.so /opt/gnome2/lib64/libpangoft2-1.0.so /opt/gnome2/lib64/libcairo.so /opt/gnome2/lib64/libpixman-1.so -lpng12 -lXrender /opt/gnome2/lib64/libpango-1.0.so /opt/gnome2/lib64/libfontconfig.so -lfreetype /opt/gnome2/lib64/libexpat.so /opt/gnome2/lib64/libgio-2.0.so -lresolv -lselinux -lX11 /opt/gnome2/lib64/libgnome-keyring.so /opt/gnome2/lib64/libgcrypt.so /opt/gnome2/lib64/libgpg-error.so /opt/gnome2/lib64/libgconf-2.so /opt/gnome2/lib64/libORBit-2.so /opt/gnome2/lib64/libgmodule-2.0.so -ldl /opt/gnome2/lib64/libdbus-glib-1.so /opt/gnome2/lib64/libdbus-1.so /opt/gnome2/lib64/libgobject-2.0.so /opt/gnome2/lib64/libgthread-2.0.so -lpthread -lrt /opt/gnome2/lib64/libglib-2.0.so -lz -lm -pthread -Wl,-rpath -Wl,/opt/gnome2/lib64
make[3]: Leaving directory `/home/oxyde/gnome2/evince/shell'
make[2]: Leaving directory `/home/oxyde/gnome2/evince/shell'
make[1]: Leaving directory `/home/oxyde/gnome2/evince'
ev-media-player-keys.o: In function `ev_media_player_keys_init':
/home/oxyde/gnome2/evince/shell/ev-media-player-keys.c:166: undefined reference to `g_bus_watch_proxy'
ev-media-player-keys.o: In function `ev_media_player_keys_finalize':
/home/oxyde/gnome2/evince/shell/ev-media-player-keys.c:193: undefined reference to `g_bus_unwatch_proxy'
../cut-n-paste/totem-screensaver/.libs/libtotemscrsaver.a(libtotemscrsaver_la-totem-scrsaver.o): In function `screensaver_init_dbus':
/home/oxyde/gnome2/evince/cut-n-paste/totem-screensaver/totem-scrsaver.c:251: undefined reference to `g_bus_watch_proxy'
../cut-n-paste/totem-screensaver/.libs/libtotemscrsaver.a(libtotemscrsaver_la-totem-scrsaver.o): In function `screensaver_finalize_dbus':
/home/oxyde/gnome2/evince/cut-n-paste/totem-screensaver/totem-scrsaver.c:274: undefined reference to `g_bus_unwatch_proxy'
collect2: ld returned 1 exit status
make[3]: *** [evince] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Comment 1 Carlos Garcia Campos 2010-06-17 12:45:53 UTC
Yes, known issue, I'm just waiting for a new glib release with the new api.
Comment 2 Carlos Garcia Campos 2010-06-17 13:31:06 UTC
*** Bug 621884 has been marked as a duplicate of this bug. ***
Comment 3 Claudio Saavedra 2010-06-17 14:18:59 UTC
Created attachment 163918 [details] [review]
partially fix the build

This is untested but based in the patch for nautilus in bug 621879. It only fixes the part for the mediakeys, as Carlos suggested in irc to have already a patch for the other part.
Comment 4 Carlos Garcia Campos 2010-06-17 14:28:48 UTC
Yes, there's a patch for the totem part attached to bug #621445. Patch looks good, I'll test and push it as sson as glib and gtk+ is released. Thanks!
Comment 5 Claudio Saavedra 2010-06-17 22:39:06 UTC
Created attachment 163971 [details] [review]
new patch

This checks for proxy not to be NULL, in case of error.
Comment 6 Carlos Garcia Campos 2010-06-18 09:30:44 UTC
Pushed to git master with a minor modification (use no_load_props flag). Thanks!