After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621730 - Do not dist gir_DATA
Do not dist gir_DATA
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks: 621611
 
 
Reported: 2010-06-16 04:20 UTC by Yaakov Selkowitz
Modified: 2010-09-06 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not dist gir_DATA (1.00 KB, patch)
2010-06-16 04:20 UTC, Yaakov Selkowitz
none Details | Review

Description Yaakov Selkowitz 2010-06-16 04:20:40 UTC
Attaching patch for git master below.
Comment 1 Yaakov Selkowitz 2010-06-16 04:20:43 UTC
Created attachment 163779 [details] [review]
Do not dist gir_DATA

GIR files contain a shared-library attribute which varies per platform,
and therefore must not be disted; see bug 621611 for rationale.
Comment 2 Christian Persch 2010-06-16 09:58:58 UTC
Shouldn't that be "nodist_gir_DATA" then?
Comment 3 Yaakov Selkowitz 2010-06-16 18:35:24 UTC
From the automake manual[1]:
> By default, data files are not included in a distribution. Of course, 
> you can use the dist_ prefix to change this on a per-variable basis.

[1] http://www.gnu.org/software/automake/manual/html_node/Data.html
Comment 4 Johan (not receiving bugmail) Dahlin 2010-09-06 04:33:18 UTC
Can this be committed?
Comment 5 Christian Persch 2010-09-06 10:50:28 UTC
This is already fixed on master.