After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621634 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Product: ekiga
Classification: Applications
Component: Build System
GIT master
Other Linux
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
Depends on: 611709
Blocks: 585391
Reported: 2010-06-15 12:23 UTC by André Klapper
Modified: 2013-10-22 12:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

configure log (106.30 KB, text/plain)
2013-10-21 22:08 UTC, dbordak

Description André Klapper 2010-06-15 12:23:01 UTC
This module does not build with -DGSEAL_ENABLE.
See .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see for current status.

Output (not necessarily complete):

../lib/gui/gmlevelmeter.c: In function »gm_level_meter_realize«:
../lib/gui/gmlevelmeter.c:365: Error: »GtkObject« has no member named 'flags'
../lib/gui/gmmenuaddon.c: In function ‘menu_item_selected’:
../lib/gui/gmmenuaddon.c:143: error: ‘GtkStatusbar’ has no member named ‘messages’
../lib/gui/gmstatusbar.c: In function ‘gm_sb_push_message’:
../lib/gui/gmstatusbar.c:113: error: ‘GtkStatusbar’ has no member named ‘messages’
Comment 1 Snark 2010-06-15 14:09:43 UTC
For the first error, the code is :
so any fix in gtk+ will flow on us... we do not need to move.

See bug #611709, which is what the GtkStatusbar->messages messages are about : we will be able to fix it when the modified gtk+ gets in distributions.
Comment 2 André Klapper 2010-06-15 14:13:38 UTC
> we do not need to move.

Huh? I don't get that. GTK_WIDGET_SET_FLAGS in general is deprecated and remove for GTK 3.0. You have to switch to a non-deprecated setter function in the Ekiga code itself.

For GtkStatusbar->messages would it be acceptable to use
  #if GTK_CHECK_VERSION (2,21,0)
in the Ekiga code in order to be able to continue shipping Ekiga in GNOME 2.31.x?
Comment 3 Snark 2010-06-15 15:23:03 UTC
Oups. My bad.

I pushed a change which still compiles, and should compile with a newer gtk+ and the GSEAL_ENABLE flags.
Comment 4 André Klapper 2010-06-16 09:35:23 UTC
Hi Snark, thanks!

May I (or can you) in lib/gui/gmstatusbar.c and lib/gui/gmmenuaddon.c please change
   #if GTK_CHECK_VERSION (2, 22, 0)
   #if GTK_CHECK_VERSION (2, 21, 2)
so Ekiga successfully compiles in jhbuild (the fix for bug 611709 is included in gtk+ 2.21.2)?
Comment 5 Eugen Dedu 2010-06-16 09:41:42 UTC
Please make the change.
Comment 7 Eugen Dedu 2010-12-17 16:34:54 UTC
For info, there are several files which currently do not compile with GSEAL:

They will be fixed a bit later (before gnome 3.0), once gtk 2.22 appears in debian, the distribution we use...
Comment 8 Eugen Dedu 2011-02-05 21:10:39 UTC
William, why have you removed 3.0 target?
Comment 9 André Klapper 2011-02-06 01:41:20 UTC
(In reply to comment #8)
> William, why have you removed 3.0 target?

Because Ekiga is not part of GNOME Core moduleset.
Comment 10 dbordak 2013-10-21 21:17:09 UTC
This bug appears to have been fixed? I had no problem in compiling ekiga with -DGSEAL_ENABLE, though I see that this affected Gnome 2, which I do not expect is relevant any longer?
Comment 11 dbordak 2013-10-21 22:08:54 UTC
Created attachment 257800 [details]
configure log

I apologize for not including this with the previous message. This was the logged output from configure, the following build (using make with no parameters) successfully compiled.
Comment 12 Eugen Dedu 2013-10-22 12:51:41 UTC
Indeed, it is surely fixed with gtk3 commits.