GNOME Bugzilla – Bug 621629
live-search: should select first matching contact
Last modified: 2010-07-29 15:09:55 UTC
We should "select" the first match when searching so we can start a chat by hitting "enter" or move bewteen matches using the arrow keys.
I would like to add that when a contact is selected in the filtered mode, closing the livesearch should make sure to keep that selected item visible.
the arrow keys are not usable any more in the treeview at the moment. this could be a regression of live search, but should be fixed when this bug is fixed. I guess that the entry catches the arrow key press events.
http://git.collabora.co.uk/?p=user/kaserf/empathy.git;a=shortlog;h=refs/heads/select-first-match-621629 this patch needs a review. what I'm not happy with at the moment is the flickering when the search is closed and the contact is kept visible with gtk_tree_view_scroll_to_cell, but I don't know how to improve that. :(
This particular bug is already fixed actually, I made a patch to select first row if there was no selection yet. But that branch contains more than that. - It make sure selection keep visible when hiding the live search, => Felix said there is a flickering issue, have to investiguate. - make keys up/down work on the treeview. => But that's done only when live search is not shown... when the entry is visible we should still forward up/down to the treeview afaik.
*** Bug 625037 has been marked as a duplicate of this bug. ***
there is a new patch to review. it can be found here: http://git.collabora.co.uk/?p=user/kaserf/empathy.git;a=shortlog;h=refs/heads/select-first-match-621629 it solves the issue and contains a commit which changes the empathy-contact-list-view.c as well, call it legacy change or whatever, since that class will be substituted by empathy-individual-view.c
(In reply to comment #4) > This particular bug is already fixed actually, I made a patch to select first > row if there was no selection yet. > > But that branch contains more than that. > > - It make sure selection keep visible when hiding the live search, > => Felix said there is a flickering issue, have to investiguate. fixed > > - make keys up/down work on the treeview. > => But that's done only when live search is not shown... when the entry is > visible we should still forward up/down to the treeview afaik. fixed the branch has been merged to master, closing the bug