After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621525 - should not use "site-packages/gtk-2.0" dir
should not use "site-packages/gtk-2.0" dir
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-14 10:20 UTC by Paolo Borelli
Modified: 2010-11-30 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not install gi in the gtk-2.0 directory. (1.66 KB, patch)
2010-06-15 11:56 UTC, Steve Frécinaux 		none Details | Review
Do not install gi in the gtk-2.0 directory. (2.37 KB, patch)
2010-06-15 12:15 UTC, Steve Frécinaux 		none Details | Review

Description Paolo Borelli 2010-06-14 10:20:22 UTC 
currently pygi isntalls modules in python2.6/site-packages/gtk-2.0/gi

I think we should change that directory while we still can (no stable version released yet)

 - it should not use "gtk" since pygi operates at a lower level and binds stuff outside of gtk
 - it should not use 2.0 since even today it is working with gtk 3
Comment 1 Tomeu Vizoso 2010-06-14 10:21:52 UTC 
I agree about this. Anybody remembers why are installing inside gtk-2.0/?
Comment 2 Steve Frécinaux 2010-06-15 11:56:13 UTC 
Created attachment 163670 [details] [review]
Do not install gi in the gtk-2.0 directory.
Comment 3 Johan (not receiving bugmail) Dahlin 2010-06-15 12:14:17 UTC 
The reason was for parallel installs. Someone need to figure out what needs to be done so gtk 2.x and 3.x can be used at the same time (on different processes of course) on the same system.
Comment 4 Steve Frécinaux 2010-06-15 12:15:42 UTC 
Created attachment 163672 [details] [review]
Do not install gi in the gtk-2.0 directory.

Also remove the requirement for pygtk 2.0 in the tests.
Comment 5 Tomeu Vizoso 2010-06-15 12:16:14 UTC 
(In reply to comment #3)
> The reason was for parallel installs. Someone need to figure out what needs to
> be done so gtk 2.x and 3.x can be used at the same time (on different processes
> of course) on the same system.

I was hoping we would be able to keep pygobject (and pygi) working with both gtk 2.x and 3.x.
Comment 6 Steve Frécinaux 2010-07-26 10:33:36 UTC 
I think this patch is obsoleted by the merge of pygi into pygobject.
Comment 7 Tomeu Vizoso 2010-07-26 11:53:07 UTC 
(In reply to comment #6)
> I think this patch is obsoleted by the merge of pygi into pygobject.

Are you sure? I get my modules installed in site-packages/gtk-2.0/gi
Comment 8 Simon van der Linden 2010-07-30 14:29:30 UTC 
As of today, gi modules are still installed in site-packages/gtk-2.0/gi/.

We can move them wherever we want, but gi depends on gobject that is loaded from the site-packages/gtk-2.0 (which doesn't seem right either).
Comment 9 johnp 2010-09-23 15:21:59 UTC 
ping.  would like to get a decision this.  Can someone update the patch if they think it is important (I know for testing the gtk-2.0 directory screws up modules installed to lib64 and I have to manually add to PYTHONPATH).  Does moving the module screw up anything?  As far as parallel usage of Gtk-2/3 this is not an issue because it is a matter of either using PyGTK or PyGI.  PyGI should have a way of selecting gir versions but that does not require the current directory structure.

I'm doing a release soon.  Let's make a decision after that release.
Comment 10 johnp 2010-11-29 21:47:11 UTC 
Ok, I cleaned up and committed.  Make sure you clean out the gtk-2.0 directory in your buildroot/installroot.  Please test with legacy static modules to make sure we don't break everything.
Comment 11 johnp 2010-11-30 22:14:58 UTC 
Closing this.  Please reopen if there are issues