After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621523 - [id3mux] write beats-per-minute tag
[id3mux] write beats-per-minute tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-14 10:12 UTC by Jonathan Matthew
Modified: 2010-08-04 23:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch + tests (18.55 KB, patch)
2010-06-14 10:12 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2010-06-14 10:12:36 UTC 
Created attachment 163567 [details] [review]
patch + tests

id3mux currently doesn't support the beats-per-minute tag.
ID3 uses the TBPM frame to store beats-per-minute as an integer rather than a
double as it is in GStreamer tag lists.

id3mux also doesn't have any tests, so I copied the id3v2mux tests in and made them run for both id3v2.3 and v2.4.
Comment 1 Tim-Philipp Müller 2010-08-04 23:00:02 UTC 
Thanks!

 commit 76311f2ef0c6d9e8b55dc20ab342775046574dd7
 Author: Jonathan Matthew <jonathan@d14n.org>
 Date:   Mon Jun 14 20:07:33 2010 +1000

    id3mux: add support for beats-per-minute tag
    
    Write beats per minute into the TBPM frame, and add unit
    test for id3mux, based on id3v2mux unit test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621523