After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621518 - Refactoring orca_prefs and its calls
Refactoring orca_prefs and its calls
Status: RESOLVED OBSOLETE
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
3.0!
Depends on:
Blocks: Andalucia 619745
 
 
Reported: 2010-06-14 09:44 UTC by Javier Hernández
Modified: 2011-03-05 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
orca_prefs refactor (2.42 KB, patch)
2010-06-14 09:53 UTC, Javier Hernández 		none Details | Review

Description Javier Hernández 2010-06-14 09:44:52 UTC 
I have the need to refactor this for homogenize calls to orca_prefs.writePreferences method.

I have a branch in gitorious (http://gitorious.org/~jhernandez/orca-mirror/jhernandez-orca-mirror/commits/orcaPrefs-mods) with these slightly changes and added an attachment to this bug too, could anyone review it? 

Thanks!
Comment 1 Javier Hernández 2010-06-14 09:53:51 UTC 
Created attachment 163565 [details] [review]
orca_prefs refactor
Comment 2 Alejandro Leiva 2010-06-14 10:27:47 UTC 
(In reply to comment #0)
> I have the need to refactor this for homogenize calls to
> orca_prefs.writePreferences method.
> 
> I have a branch in gitorious
> (http://gitorious.org/~jhernandez/orca-mirror/jhernandez-orca-mirror/commits/orcaPrefs-mods)
> with these slightly changes and added an attachment to this bug too, could
> anyone review it? 
> 
> Thanks!

I'm with you. I don't understand why is needed polymorphism in this method. 

Maybe we're missing something.
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-06-14 17:47:46 UTC 
> I'm with you. I don't understand why is needed polymorphism in this method. 
> 
> Maybe we're missing something.

Or not.... :-) I don't know why Rich did it that way. On the one hand, Rich always had a good reason for doing things the way he did; on the other hand, I don't see any problem with this change.

Ale, if Javi's change makes sense to you, please feel free to commit the change to master and close this one out as FIXED. Thanks!
Comment 4 Javier Hernández 2010-06-15 10:08:36 UTC 
One appointment!

This refactor is an approximation and I think that commit this slightly changes to master takes no sense at the moment. Maybe I'll need to make more changes in orca_prefs this week, so, we will keep this bug open to track orca_prefs modifications.

Regards!
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-06-15 10:10:16 UTC 
Javi this applies to OpenSolaris as well. If I change it from Linux to All for that reason, please don't change it back.

Thanks!
Comment 6 Javier Hernández 2010-06-15 10:19:09 UTC 
Ok Joanmarie!
Comment 7 Joanmarie Diggs (IRC: joanie) 2010-07-05 02:44:52 UTC 
(3.0 Planning Spam-o-rama. Sorry!)
Comment 8 Trevor Saunders (IRC: tbsaunde) 2011-01-07 20:04:23 UTC 
what is the status of this, is work still needed?
Comment 9 Trevor Saunders (IRC: tbsaunde) 2011-03-05 22:18:12 UTC 
It seems like this is either fixed, or nolonger an issue, please reopen if there's something that needs fixed.