GNOME Bugzilla – Bug 621516
More maps integration in addressbooks and calendars: Calendar events on maps
Last modified: 2021-05-19 11:38:04 UTC
Created attachment 163562 [details] [review] A patch to implement the features Some nice feature to add: * Show calendar events on maps * Some more integration with contacts The attached patch is adding those features but contain some tiny problems to fix: * the address parsed in the calendar event location can only be US-formatted addresses. Some work is ongoing on that point. * the focus chain of the new location details dialog isn't correct
I've noticed that you are using synchronous method to resolve GPS coordinates from address, which is definitely not OK (this applies for the original contact-maps plugin too - try to open map for 200 contacts with a slow connection). Use geoclue_geocode_address_to_position_async() instead. Since you are integrating the map feature directly into the Evolution on some places, I think it would make sense, to merge this with bug 642557, creating a common function to resolve GPS coordinates and put markers on widget which would return prepared champlain widget and then just call it from various places in Evo. I would definitely merge the "all contacts map" and the event map with the bug 642557, but I'm not sure abou the single contact map, since the other bug provides the same directly within the contacts preview, which I think is a better feature ;) Have you tested the single full-width map as we discussed on IRC yet?
Cedric: Are you still around and could answer Dan's comments here?
André, Dan, I'm still around, though I don't have time for evolution these days. Feel free to do whatever is needed with that patch. I didn't have time to test the single full-width map yet... do it as you like it would be already better than nothing ;)
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/evolution/-/issues/ Thank you for your understanding and your help.