After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621509 - [xmptag] Uses uninitialized variable
[xmptag] Uses uninitialized variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal major
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-14 09:02 UTC by Sebastian Dröge (slomo)
Modified: 2010-06-14 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2010-06-14 09:02:58 UTC
Hi,
deserialize_exif_gps_coordinate() in gstxmptag.c uses the variable c uninitialized if the string contains no minutes, i.e. only the degrees.

Not sure how c should be initialized, that's why I'm filing this bug ;)
Comment 1 Thiago Sousa Santos 2010-06-14 18:49:13 UTC
Pushed this fix:


commit 4219a5ae5c7ee8cab7db9bcf53207d46173f4b63
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Mon Jun 14 15:05:16 2010 -0300

    tag: xmp: Init char variable for gps coordinates
    
    Initialize char variable for gps coordinates deserialization to 0
    to identify when it couldn't be parsed/found and error out.
    
    Fixes #621509


Thanks.