After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621508 - TagLib support for CR2 files
TagLib support for CR2 files
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Metadata
GIT
Other All
: Normal normal
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 618683
 
 
Reported: 2010-06-14 08:47 UTC by Mike Gemünde
Modified: 2010-06-24 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Introduce the class BaseTiffFile as base for all Tiff-based file formats (10.15 KB, patch)
2010-06-14 08:47 UTC, Mike Gemünde
committed Details | Review
Add Property Writeable to Image.File (1.14 KB, patch)
2010-06-14 08:47 UTC, Mike Gemünde
committed Details | Review
Add support for Canon CR2 raw files (11.95 KB, patch)
2010-06-14 08:47 UTC, Mike Gemünde
committed Details | Review
Extend the ParsePhoto example to also show the image size (1.00 KB, patch)
2010-06-14 08:47 UTC, Mike Gemünde
committed Details | Review

Description Mike Gemünde 2010-06-14 08:47:28 UTC
These commits implement support for CR2 files. For now, there are no test included
because of the huge data of CR2 files.
Comment 1 Mike Gemünde 2010-06-14 08:47:30 UTC
Created attachment 163553 [details] [review]
Introduce the class BaseTiffFile as base for all Tiff-based file formats

The class BaseTiffFile is introduced to factor out some behavior which is
common for all Tiff-based file formats.
Comment 2 Mike Gemünde 2010-06-14 08:47:34 UTC
Created attachment 163554 [details] [review]
Add Property Writeable to Image.File

Since we start supporting some file formats just for reading
(at least for now) the property Writeable is added to Image.File
to indicate if a file can be written back or not.
Comment 3 Mike Gemünde 2010-06-14 08:47:37 UTC
Created attachment 163555 [details] [review]
Add support for Canon CR2 raw files

This commits adds support to parse Canon CR2 RAW files. Since this
format is based on the TIFF structure, reading is mostly based on
this code.
Comment 4 Mike Gemünde 2010-06-14 08:47:41 UTC
Created attachment 163556 [details] [review]
Extend the ParsePhoto example to also show the image size
Comment 5 Ruben Vermeersch 2010-06-19 13:17:56 UTC
Review of attachment 163553 [details] [review]:

Looks clean.
Comment 6 Ruben Vermeersch 2010-06-19 13:18:54 UTC
Review of attachment 163554 [details] [review]:

Cool, be sure to add a check to the unit tests that *demands* that a file is writable. Also, like you said: the readonly test should only work for files that are !Writable. That way we ensure that writing is always tested.
Comment 7 Ruben Vermeersch 2010-06-19 13:20:43 UTC
Review of attachment 163555 [details] [review]:

Love how clean it is to add a RAW type that derives from Tiff.

::: src/TagLib/Cr2/Codec.cs
@@ +41,3 @@
+		///    of the media represented by the current instance.
+		/// </value>
+		public override string Description { get { return "CR2 File"; } }

Probably better to call this "Canon RAW File".
Comment 8 Ruben Vermeersch 2010-06-19 13:22:12 UTC
Review of attachment 163556 [details] [review]:

Shocked that we didn't have this yet.
Comment 9 Ruben Vermeersch 2010-06-20 13:58:54 UTC
Attachment 163556 [details] pushed as e51a0cc - Extend the ParsePhoto example to also show the image size


Merged, great stuff! One step closer to world domination :-)