After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621461 - Automatically set GI_TYPELIB_PATH
Automatically set GI_TYPELIB_PATH
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2010-06-13 16:18 UTC by Steve Frécinaux
Modified: 2010-06-14 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Automatically set GI_TYPELIB_PATH (1.17 KB, patch)
2010-06-13 16:18 UTC, Steve Frécinaux
needs-work Details | Review
Automatically set GI_TYPELIB_PATH (1.17 KB, patch)
2010-06-14 12:52 UTC, Steve Frécinaux
none Details | Review
Automatically set GI_TYPELIB_PATH (1.25 KB, patch)
2010-06-14 12:54 UTC, Steve Frécinaux
none Details | Review
Automatically set GI_TYPELIB_PATH (1.25 KB, patch)
2010-06-14 12:56 UTC, Steve Frécinaux
none Details | Review
Automatically set GI_TYPELIB_PATH (1.25 KB, patch)
2010-06-14 13:15 UTC, Steve Frécinaux
none Details | Review
Automatically set GI_TYPELIB_PATH (1.29 KB, patch)
2010-06-14 13:17 UTC, Steve Frécinaux
committed Details | Review

Description Steve Frécinaux 2010-06-13 16:18:43 UTC
This env var is required to be able to run stuff that depend on
gobject-introspection.
Comment 1 Steve Frécinaux 2010-06-13 16:18:46 UTC
Created attachment 163516 [details] [review]
Automatically set GI_TYPELIB_PATH
Comment 2 Johan (not receiving bugmail) Dahlin 2010-06-14 12:45:31 UTC
Review of attachment 163516 [details] [review]:

Needs a bit of additional work

::: jhbuild/config.py
@@ +345,3 @@
 
+        # GI_TYPELIB_PATH
+        if os.environ.get('GI_TYPELIB_PATH') is None:

if not 'GI_TYPELIB_PATH' in os.environ:

@@ +346,3 @@
+        # GI_TYPELIB_PATH
+        if os.environ.get('GI_TYPELIB_PATH') is None:
+            if os.path.exists('/usr/lib/girepository-1.0'):

Use os.path.join

@@ +348,3 @@
+            if os.path.exists('/usr/lib/girepository-1.0'):
+                addpath('GI_TYPELIB_PATH', '/usr/lib/girepository-1.0')
+        typelibpath = os.path.join(self.prefix, 'lib', 'girepository-1.0')

libdir is correct here, as it takes lib64 into account.
Comment 3 Steve Frécinaux 2010-06-14 12:52:35 UTC
Created attachment 163583 [details] [review]
Automatically set GI_TYPELIB_PATH

The previous patch was based on the section for PKG_CONFIG_PATH, but the
new one is following jdahlin's directives instead.
Comment 4 Steve Frécinaux 2010-06-14 12:54:23 UTC
Created attachment 163584 [details] [review]
Automatically set GI_TYPELIB_PATH

I attached the wrong patch...
Comment 5 Steve Frécinaux 2010-06-14 12:56:20 UTC
Created attachment 163585 [details] [review]
Automatically set GI_TYPELIB_PATH

Same with indentation fixed.
Comment 6 Steve Frécinaux 2010-06-14 13:15:44 UTC
Created attachment 163586 [details] [review]
Automatically set GI_TYPELIB_PATH

Use self.use_lib64
Comment 7 Steve Frécinaux 2010-06-14 13:17:30 UTC
Created attachment 163587 [details] [review]
Automatically set GI_TYPELIB_PATH
Comment 8 Johan (not receiving bugmail) Dahlin 2010-06-14 13:19:46 UTC
Review of attachment 163587 [details] [review]:

This looks good
Comment 9 Steve Frécinaux 2010-06-14 14:04:47 UTC
Attachment 163587 [details] pushed as dcda5c0 - Automatically set GI_TYPELIB_PATH