After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621413 - Maximize/Unmaximize not behaving properly for some non-gnome based programs
Maximize/Unmaximize not behaving properly for some non-gnome based programs
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-13 00:06 UTC by Aaron Hankin
Modified: 2010-06-15 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix problem with window unmaximization (1.60 KB, patch)
2010-06-14 20:46 UTC, Owen Taylor
committed Details | Review

Description Aaron Hankin 2010-06-13 00:06:26 UTC
Double clicking the window title bar should maximize/unmaximize(restore to original size) the window. This is not working for me for a few specific programs: firefox, xchat, and google chrome. The window will maximize fine, but when you go to restore the window it will flash and then remain the same size as the maximized window. 

This will also happen if you right click the window title bar and click the maximize/unmaximize command, and also if you use set the 'toggle maximization state' shortcut in the   Control Center->Personal->Keyboard Shortcuts   menu. The below pictures depict what is happening.

Click maximize:    http://img810.imageshack.us/i/beforemaximize.png/
Click unmaximize:  http://img41.imageshack.us/i/clickingunmaximize.png/
Unmaximize result: http://img21.imageshack.us/i/unmaximizeresult.png/


The same problem DOES NOT occur if I use the maximize/restore window button at the upper-right-hand corner of the window next to the close button.
Comment 1 Aaron Hankin 2010-06-13 04:00:22 UTC
If forgot to add that I'm running the latest build of gnome-shell as of 06/12/2010 on Ubuntu lucid 10.04.
Comment 2 Owen Taylor 2010-06-14 20:19:08 UTC
Reproduced using plain Mutter, no gnome-shell, reassigning.
Comment 3 Owen Taylor 2010-06-14 20:46:13 UTC
Created attachment 163629 [details] [review]
Fix problem with window unmaximization

A mismerge of the Metacity commit "4943d79 Prevent window self-maximisation"
caused the window's user set size and position to be saved *before*
actually resizing the window to the unmaximized position rather than after.

This meant that after unmaximization the window was in an inconsistent
state and anything that caused a resize to be queued (like a change in
window properties by the application) would cause it to pop back to
the maximized size and position.
Comment 4 Tomas Frydrych 2010-06-15 07:22:53 UTC
Comment on attachment 163629 [details] [review]
Fix problem with window unmaximization

Looks good.
Comment 5 Aaron Hankin 2010-06-15 13:53:34 UTC
The patch fixes the problem for me. Thanks.
Comment 6 Owen Taylor 2010-06-15 17:34:05 UTC
Attachment 163629 [details] pushed as ff5a73d - Fix problem with window unmaximization