GNOME Bugzilla – Bug 621404
[dvbsrc] Set stats-reporting-interval on construction
Last modified: 2010-08-06 10:31:15 UTC
The default value is set 100 but the property is not set when the object is constructed thus the default value is never set.
Created attachment 163487 [details] [review] Added G_PARAM_CONSTRUCT
Created attachment 167227 [details] [review] dvbsrc: align actual default values for properties with defaults in param spec G_PARAM_CONSTRUCT works as a solution, but in GStreamer we don't use that really, we have DEFAULT_ defines and then assign the values in the instance init function, so let's do that instead. There were many other properties where the actual defaults didn't line up with the alleged defaults. I hope this doesn't break anything. gst-inspect-0.10 diff looks like this: @@ -94,7 +94,7 @@ Unsigned Integer. Range: 0 - 4294967295 Default: 0 Current: 0 bandwidth : Bandwidth (DVB-T) flags: readable, writable - Enum "GstDvbSrcBandwidth" Default: 1, "7" Current: 0, "8" + Enum "GstDvbSrcBandwidth" Default: 1, "7" Current: 1, "7" (0): 8 - 8 (1): 7 - 7 (2): 6 - 6 @@ -114,7 +114,7 @@ (9): - AUTO code-rate-lp : Low Priority Code Rate (DVB-T) flags: readable, writable - Enum "GstDvbSrcCode_Rate" Default: 1, "1/2" Current: 0, "NONE" + Enum "GstDvbSrcCode_Rate" Default: 1, "1/2" Current: 1, "1/2" (0): NONE - NONE (1): 1/2 - 1/2 (2): 2/3 - 2/3 @@ -127,7 +127,7 @@ (9): - AUTO guard : Guard Interval (DVB-T) flags: readable, writable - Enum "GstDvbSrcGuard" Default: 1, "16" Current: 0, "32" + Enum "GstDvbSrcGuard" Default: 1, "16" Current: 1, "16" (0): 32 - 32 (1): 16 - 16 (2): 8 - 8 @@ -135,7 +135,7 @@ (4): AUTO - AUTO modulation : Modulation (DVB-T and DVB-C) flags: readable, writable - Enum "GstDvbSrcModulation" Default: 1, "QAM 16" Current: 0, "QPSK" + Enum "GstDvbSrcModulation" Default: 1, "QAM 16" Current: 1, "QAM 16" (0): QPSK - QPSK (1): QAM 16 - QAM 16 (2): QAM 32 - QAM 32 @@ -147,13 +147,13 @@ (8): 16VSB - 16VSB trans-mode : Transmission Mode (DVB-T) flags: readable, writable - Enum "GstDvbSrcTransmission_Mode" Default: 1, "8k" Current: 0, "2k" + Enum "GstDvbSrcTransmission_Mode" Default: 1, "8k" Current: 1, "8k" (0): 2k - 2k (1): 8k - 8k (2): AUTO - AUTO hierarchy : Hierarchy Information (DVB-T) flags: readable, writable - Enum "GstDvbSrcHierarchy" Default: 1, "1" Current: 0, "NONE" + Enum "GstDvbSrcHierarchy" Default: 1, "1" Current: 1, "1" (0): NONE - NONE (1): 1 - 1 (2): 2 - 2 @@ -164,10 +164,10 @@ Pointer. Write only inversion : Inversion Information (DVB-T and DVB-C) flags: readable, writable - Enum "GstDvbSrcInversion" Default: 1, "ON" Current: 0, "OFF" + Enum "GstDvbSrcInversion" Default: 1, "ON" Current: 1, "ON" (0): OFF - OFF (1): ON - ON (2): AUTO - AUTO stats-reporting-interval: The number of reads before reporting frontend stats flags: readable, writable - Unsigned Integer. Range: 0 - 4294967295 Default: 100 Current: 0 + Unsigned Integer. Range: 0 - 4294967295 Default: 100 Current: 100
Comment on attachment 167227 [details] [review] dvbsrc: align actual default values for properties with defaults in param spec Looks good IMHO
Oh well, committed. If it causes problems, we can still fix it during the freeze. commit e2571b9f46038a962a306aa71df11e1e21161834 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Fri Aug 6 01:56:29 2010 +0100 dvbsrc: align actual default values for properties with defaults in param spec https://bugzilla.gnome.org/show_bug.cgi?id=621404