After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621402 - control + tab should switch to a new tab
control + tab should switch to a new tab
Status: RESOLVED DUPLICATE of bug 599650
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-12 21:20 UTC by Josh
Modified: 2010-06-16 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ctrl+Tab, Ctrl+Shift+Tab key_press_event handler PATCH (3.25 KB, patch)
2010-06-14 14:22 UTC, Jirka Daněk
none Details | Review

Description Josh 2010-06-12 21:20:26 UTC
All that control + tab currently does is selects the current tab or the text entry box.  In my opinion it should simply switch to the next (or previous, with control + shift + tab) tab
Comment 1 Jirka Daněk 2010-06-14 14:22:22 UTC
Created attachment 163594 [details] [review]
Ctrl+Tab, Ctrl+Shift+Tab key_press_event handler PATCH

Hi,

I tried to do something about it. These are sort of standard shortcuts and people can get very upset if they found them not working. [https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/256478/comments/9]

I first tried to do it via accel groups, but it didn't work. And I found the gtk_binding_entry_* stuff -- Inkscape somehow does it this way -- too complicated for me.

  * So I did a key_press_event handler. I am not sure you will like it.
  * Also, I had to make two static methods nonstatic, I'm not sure about the consequences, but it seems to be working for me.
  * And for some reason I have to check for GDK_ISO_Left_Tab key, instead just for GDK_Tab.

I am absolutely new to GTK (like 4 hours :P, so I expect I'll have to work on it a little bit more. Thank you for your help.
Comment 2 Jirka Daněk 2010-06-15 09:51:37 UTC
Well, this issue seems to be bigger than I've previously thought

Thread On Ctrl+Tab on GNOME mailing list:
[http://www.mail-archive.com/desktop-devel-list@gnome.org/msg17811.html]

And I see a some at first Empathy related conversations turning into debates on GNOME GUI Guidelines, like here
[https://bugs.launchpad.net/empathy/+bug/504405]
[https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/458279]
Comment 3 Guillaume Desmottes 2010-06-16 12:20:19 UTC
Thanks for your bug. I close this bug as a dup of bug #599650 as that's basically the same. Please comment there.

*** This bug has been marked as a duplicate of bug 599650 ***