After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621375 - fails to import raw from Camera
fails to import raw from Camera
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Import
GIT
Other Linux
: Normal blocker
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-12 13:51 UTC by Maxxer
Modified: 2010-06-13 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Try being less fragile in Tiff Date parsing. (1.45 KB, patch)
2010-06-13 13:19 UTC, Ruben Vermeersch 		committed Details | Review

Description Maxxer 2010-06-12 13:51:49 UTC 
I am trying to import some raw+jpeg images from Canon 450D, but it fails with the following exception:

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object
  at FSpot.Tiff.TiffFile.get_Date () [0x00021] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:2044 
  at FSpot.Import.ImportController.FindImportDestination (Hyena.SafeUri uri) [0x0001b] in /home/maxxer/work/fspot/git/src/Import/ImportController.cs:346 
  at FSpot.Import.ImportController.ImportPhoto (IBrowsableItem item, FSpot.Roll roll) [0x00000] in /home/maxxer/work/fspot/git/src/Import/ImportController.cs:294 
  at FSpot.Import.ImportController.DoImport () [0x000fa] in /home/maxxer/work/fspot/git/src/Import/ImportController.cs:231 



right before that, fails to read thumbs:
[1 Debug 15:45:51.937] Received controller event: ImportStarted
[5 Error 15:45:54.004] Error loading Subdirectory ExifIfdPointer at 270: 
FSpot.Tiff.ShortReadException: Short Read
  at FSpot.Tiff.DirectoryEntry.LoadExternal (System.IO.Stream stream) [0x00050] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:1765 
  at FSpot.Tiff.ImageDirectory.LoadEntries (System.IO.Stream stream) [0x00019] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:1218 
  at FSpot.Tiff.ImageDirectory.Load (System.IO.Stream stream) [0x00016] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:1170 
  at FSpot.Tiff.ImageDirectory..ctor (System.IO.Stream stream, UInt32 start_position, Endian endian) [0x00014] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:1137 
  at FSpot.Tiff.SubdirectoryEntry.LoadExternal (System.IO.Stream stream) [0x0005d] in /home/maxxer/work/fspot/git/src/Imaging/Tiff.cs:1499
Comment 1 Ruben Vermeersch 2010-06-13 13:19:49 UTC 
Created attachment 163507 [details] [review]
Try being less fragile in Tiff Date parsing.
Comment 2 Ruben Vermeersch 2010-06-13 13:21:39 UTC 
Comment on attachment 163507 [details] [review]
Try being less fragile in Tiff Date parsing.

Attachment 163507 [details] pushed as 489f2ee - Try being less fragile in Tiff Date parsing.


This will be fixed in a better way once we switch to TagLib#.

Could you test if the workaround fixes it for you?
Comment 3 Maxxer 2010-06-13 15:53:14 UTC 
yes, fixed, thanks