After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621338 - Improve GSettings usage
Improve GSettings usage
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Preferences
2.31.x
Other All
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 616362
Blocks:
 
 
Reported: 2010-06-12 01:19 UTC by Danielle Madeley
Modified: 2018-05-22 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Danielle Madeley 2010-06-12 01:19:22 UTC
There are a number of places in Empathy where a GSettings changed:: signal is being used to update the toggled/sensitive/etc. of a GtkWidget. These instances should be identified and replaced with uses of g_settings_bind()

This is the pattern to look for:

static void notify_cb (GSettings *gsettings, ...)
{
    gtk_toggle_button_set_active (toggle_button,
        g_settings_get_boolean (gsettings, key));
}

construct_ui (...)
{
    g_signal_connect (gsettings, "changed::" SOME_KEY_NAME,
        G_CALLBACK (notify_cb), something);
    notify_cb (gsettings, SOME_KEY_NAME, something);
}

It can be replaced by:

g_settings_bind (gsettings, key, widget, "property", G_SETTINGS_BIND_GET);
Comment 1 Jean-François Fortin Tam 2012-08-26 05:33:52 UTC
Danni, is this still to be done?
Comment 2 Danielle Madeley 2012-08-28 11:30:22 UTC
I did a bunch of it. grep for use of "changed::" and see what's left.
Comment 3 GNOME Infrastructure Team 2018-05-22 14:15:05 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/244.