After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621334 - GstBaseTransform should not require a transform_size function
GstBaseTransform should not require a transform_size function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.30
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-11 22:56 UTC by Olivier Crête
Modified: 2010-06-14 08:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basetransform: Assume size is the same if no transform_size/get_unit_size (1.32 KB, patch)
2010-06-11 22:58 UTC, Olivier Crête
none Details | Review
capsfilter: Remove transform_size (1.95 KB, patch)
2010-06-11 22:58 UTC, Olivier Crête
none Details | Review

Description Olivier Crête 2010-06-11 22:56:35 UTC
GstBaseTransform should not require a transform_size function. Instead, elements that don't change the size should have the option to not implement it.
Comment 1 Olivier Crête 2010-06-11 22:58:49 UTC
Created attachment 163441 [details] [review]
basetransform: Assume size is the same if no transform_size/get_unit_size

Subclasses that don't implemen transform_size should be assumed to produce output
buffers of the same size.
Comment 2 Olivier Crête 2010-06-11 22:58:52 UTC
Created attachment 163442 [details] [review]
capsfilter: Remove transform_size

GstBaseTransform now assumes that the size is the same if there is not
transform_size.
Comment 3 Wim Taymans 2010-06-14 08:57:25 UTC
these seem to be good defaults, commited.

commit 24b41d01c8f31449eb3dd1ebf8499b526acb63ab
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jun 11 18:49:02 2010 -0400

    capsfilter: Remove transform_size
    
    GstBaseTransform now assumes that the size is the same if there is not
    transform_size.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621334

commit 828f2a338964d948fa2134d8f38f6f14af98be17
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Fri Jun 11 18:46:30 2010 -0400

    basetransform: Assume size is the same if no transform_size/get_unit_size
    
    Subclasses that don't implemen transform_size should be assumed to produce output
    buffers of the same size.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=621334