After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621262 - [PATCH] imapx fetch truncated on broken servers
[PATCH] imapx fetch truncated on broken servers
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.32.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[imapx]
Depends on:
Blocks:
 
 
Reported: 2010-06-11 00:09 UTC by David Woodhouse
Modified: 2013-09-14 16:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
patch (1.01 KB, patch)
2010-06-11 00:09 UTC, David Woodhouse
accepted-commit_now Details | Review

Description David Woodhouse 2010-06-11 00:09:01 UTC
Created attachment 163352 [details] [review]
patch

Some crappy servers (Exchange) lie to us when reporting RFC822.SIZE, leading to truncated downloads. This patch works around the problem by continue to fetch chunks of data until we don't get any more data, rather than stopping at the reported size.

I removed the '!failed &&' because there was no way to hit this code with 'failed' being set anyway.

We normally have parallel fetch requests for three chunks at a time; this patch preserves that behaviour up to the advertised size, then fetches one at a time.
Comment 1 Chenthill P 2010-06-11 10:04:30 UTC
Comment on attachment 163352 [details] [review]
patch

Patch looks good. Please commit the patch to master and gnome-2-30 branch.