Created attachment 163261 [details] [review]
Let-GLIB_SETTINGS-macro-use-glib-compile-schemas-fro.patch

This second patch, when cross compiling an application, uses AC_PATH_TOOL to find glib-compile-schemas instead of using PKG_CONFIG.

Actually, I am not sure why glib uses PKG_CONFIG in the first place to find glib-compile-schemas. To me, it makes more sense to just use the standard autoconf macros for this. Nonetheless, for the non cross compiling case, I left this behaviour unchanged.

Thanks, those look good. Committed.

*** Bug 620174 has been marked as a duplicate of this bug. ***

Hib: is there a reason you used AC_PATH_TOOL instead of PROG?  Apparently this is the wrong choice since it prefixes the compiler prefix (so we end up with something like 'arm-unknown-linux-gnueabi-glib-compile-schemas').

(In reply to comment #4)
> Hib: is there a reason you used AC_PATH_TOOL instead of PROG?  Apparently this
> is the wrong choice since it prefixes the compiler prefix (so we end up with
> something like 'arm-unknown-linux-gnueabi-glib-compile-schemas').

I used AC_PATH_TOOL to allow for the possibility that glib-compile-schemas does something different depending on the platform it is supposed to compile schemas for. It allows you to have your normal glib-compile-schemas installed alongside with a compiler prefixed glib-compile-schemas (e.g. arm-unknown-linux-gnueabi-glib-compile-schemas). AC_PATH_TOOL will first search for the prefixed  glib-compile-schemas and when it does not find it, it will automatically fall back to it's none cross compile variant.

hi Hib,

That's what I guessed.  That's not the case -- the compiled schema file is the same format for every system.

I've updated TOOL to PROG in the two places.

Cheers