After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621123 - [runDialog] Fix adding entries to empty history
[runDialog] Fix adding entries to empty history
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-09 15:18 UTC by Florian Müllner
Modified: 2010-06-09 16:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[runDialog] Fix adding entries to empty history (1.21 KB, patch)
2010-06-09 15:18 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-06-09 15:18:36 UTC 
See patch.
Comment 1 Florian Müllner 2010-06-09 15:18:40 UTC 
Created attachment 163206 [details] [review]
[runDialog] Fix adding entries to empty history

Before adding a new entry to the history, we check that it does not
match the previous entry to cut down the number of duplicate entries.
Part of that condition is a check for a history length greater zero
to avoid an illegal negative index, with the side effect that nothing
is ever added while the history is empty.
Comment 2 drago01 2010-06-09 16:12:23 UTC 
Review of attachment 163206 [details] [review]:

Good catch.
Comment 3 Florian Müllner 2010-06-09 16:24:46 UTC 
Attachment 163206 [details] pushed as 51478f1 - [runDialog] Fix adding entries to empty history