After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621081 - GtkViewport missing accessor for view_window.
GtkViewport missing accessor for view_window.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 597610 615398
 
 
Reported: 2010-06-09 10:33 UTC by Cosimo Cecchi
Modified: 2010-06-09 16:25 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
patch (1.46 KB, patch)
2010-06-09 10:37 UTC, Cosimo Cecchi 		needs-work Details | Review
patch v2 (2.38 KB, patch)
2010-06-09 11:04 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2010-06-09 10:33:52 UTC 
It's needed for nautilus bug #615398.
Comment 1 Cosimo Cecchi 2010-06-09 10:37:35 UTC 
Created attachment 163183 [details] [review]
patch

Straightforward fix.
Comment 2 Emmanuele Bassi (:ebassi) 2010-06-09 10:58:05 UTC 
Review of attachment 163183 [details] [review]:

the patch it's missing the addition in gtk.symbols and in the gtk-sections.txt for the API reference.

and I guess this would be a candidate for backporting to the 2-22 branch as well.

::: gtk/gtkviewport.c
@@ +600,3 @@
+ * @viewport: a #GtkViewport
+ * gtk_viewport_get_view_window:
+/**

missing g-i annotation - should be "transfer none", if I'm not mistaken
Comment 3 Cosimo Cecchi 2010-06-09 11:04:16 UTC 
Created attachment 163187 [details] [review]
patch v2

Updated patch according to Emmanuele's comments.
Comment 4 Matthias Clasen 2010-06-09 15:23:22 UTC 
Looks good to me, and yes, please cherry-pick to gtk-2-22 as well.
Comment 5 Cosimo Cecchi 2010-06-09 16:25:14 UTC 
Committed to master and gtk-2-22.