After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621066 - (f-spot-duphash) Change duplicate detection to work on whole-file hash at import.
(f-spot-duphash)
Change duplicate detection to work on whole-file hash at import.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: 596280 602984
 
 
Reported: 2010-06-09 07:53 UTC by Ruben Vermeersch
Modified: 2010-06-11 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ruben Vermeersch 2010-06-09 07:53:27 UTC 
Duplicate detection is currently broken in subtle ways. For this reason I propose to change duplicate to work on the MD5 hash of the entire file. This hash is calculated when the file is imported and will never be recalculated.

Advantages:
* Faster, no need to generate a thumbnail
* Does perfect duplicate detection of files that come from a camera / card

Disadvantages:
* We need to nuke all the duplicate data
* Changed files which are reimported won't get the right import hash
Comment 1 Ruben Vermeersch 2010-06-09 07:56:05 UTC 
Currently there's a check in place that refuses to import a file if it would
get the same name as an existing file. No actual duplicate detection is done in
that case. Obviously this is very broken, but I suggest we leave it in place
for a couple releases, until people have a sufficient amount of new hashes in
their database (which get calculated during import). Comments?
Comment 2 Ruben Vermeersch 2010-06-11 12:16:58 UTC 
Built and merged to master.