After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621045 - Improve startup performance of the greeter
Improve startup performance of the greeter
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-06-09 00:58 UTC by William Jon McCann
Modified: 2010-06-11 00:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Clean up and correct some debug statements (1.68 KB, patch)
2010-06-09 01:29 UTC, William Jon McCann
accepted-commit_now Details | Review
Only emit user change signals after is-loaded is true (1.33 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Use avatar-default instead of stock_person (2.22 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Queue updating other user visibility instead of checking every time (6.00 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Queue chooser visibility updates (3.47 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Queue updating the selection in the user list (2.99 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Only load icons for visible items (16.17 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Remove some overly verbose debug spew (1.09 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Queue a timeout to load user data (4.40 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review
Load the default avatar for all items initially (1.05 KB, patch)
2010-06-09 01:30 UTC, William Jon McCann
none Details | Review

Description William Jon McCann 2010-06-09 00:58:42 UTC
Bug #620908 dramatically improved the performance of the user manager but it didn't address the startup performance of the greeter login window.

There are some pretty serious performance issues with that too.
Comment 1 William Jon McCann 2010-06-09 01:29:58 UTC
Created attachment 163152 [details] [review]
Clean up and correct some debug statements
Comment 2 William Jon McCann 2010-06-09 01:30:00 UTC
Created attachment 163153 [details] [review]
Only emit user change signals after is-loaded is true
Comment 3 William Jon McCann 2010-06-09 01:30:01 UTC
Created attachment 163154 [details] [review]
Use avatar-default instead of stock_person

Apparently this is the supported name in gnome-icon-theme
Comment 4 William Jon McCann 2010-06-09 01:30:03 UTC
Created attachment 163155 [details] [review]
Queue updating other user visibility instead of checking every time
Comment 5 William Jon McCann 2010-06-09 01:30:06 UTC
Created attachment 163156 [details] [review]
Queue chooser visibility updates
Comment 6 William Jon McCann 2010-06-09 01:30:08 UTC
Created attachment 163157 [details] [review]
Queue updating the selection in the user list
Comment 7 William Jon McCann 2010-06-09 01:30:10 UTC
Created attachment 163158 [details] [review]
Only load icons for visible items
Comment 8 William Jon McCann 2010-06-09 01:30:12 UTC
Created attachment 163159 [details] [review]
Remove some overly verbose debug spew
Comment 9 William Jon McCann 2010-06-09 01:30:14 UTC
Created attachment 163160 [details] [review]
Queue a timeout to load user data

This makes scrolling more responsive.
Comment 10 William Jon McCann 2010-06-09 01:30:17 UTC
Created attachment 163161 [details] [review]
Load the default avatar for all items initially

This allows the rows to size correctly and not have as dramatic
a change when we dynamically load the icon on visibility changes.
Comment 11 William Jon McCann 2010-06-09 01:34:16 UTC
These are on top of the patches in bug 610179.  Maybe they shouldn't be though.
Comment 12 Ray Strode [halfline] 2010-06-09 12:48:18 UTC
okay let's land 610179 first then.
Comment 13 William Jon McCann 2010-06-11 00:21:25 UTC
I rebased some of 610179 on top of these.  I've committed these to master.