After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620944 - Track change during deletion causes deletion of wrong file
Track change during deletion causes deletion of wrong file
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: User Interface
1.6.0
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-06-08 09:58 UTC by bob
Modified: 2020-03-17 08:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Prevents Banshee from changing the track selection until context menu is closed (1.98 KB, patch)
2011-04-30 06:04 UTC, Mackenan Grassi
none Details | Review
This is the patch I meant to upload (2.07 KB, patch)
2011-04-30 06:07 UTC, Mackenan Grassi
none Details | Review
Check if track context menu is open before letting Banshee change track selection (1.53 KB, patch)
2011-04-30 06:36 UTC, Mackenan Grassi
none Details | Review

Description bob 2010-06-08 09:58:36 UTC
I right click on a playing track and before I choose "delete", the track ends and the next one starts playing. If I then click on "delete" this won't delete my chosen track but the one now playing.
Also in the dialog which asks for confirmation there is no hint which track will be deleted. Maybe you could - in a first step - include the track name there.
Comment 1 Gabriel Burt 2010-06-10 17:48:12 UTC
Confirming - the selection is changed between the time you initiate the action and when it's actually run.
Comment 2 Mackenan Grassi 2011-04-30 06:04:17 UTC
Created attachment 186921 [details] [review]
Prevents Banshee from changing the track selection until context menu is closed

I'm not sure if this could be cleaned up at all, but it's certainly a simply way of fixing the problem. I added a conditional inside the UpdateSelection function that checks to see if the track context menu is visible. If it is, the selection stays put.
Comment 3 Mackenan Grassi 2011-04-30 06:07:29 UTC
Created attachment 186922 [details] [review]
This is the patch I meant to upload

Sorry about that. Meant to upload this one instead.
Comment 4 Mackenan Grassi 2011-04-30 06:36:49 UTC
Created attachment 186923 [details] [review]
Check if track context menu is open before letting Banshee change track selection

That's twice now. Here's the correct patch.
Comment 5 André Klapper 2020-03-17 08:54:57 UTC
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived.

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the
responsibility for active development again.
See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.