GNOME Bugzilla – Bug 620944
Track change during deletion causes deletion of wrong file
Last modified: 2020-03-17 08:54:57 UTC
I right click on a playing track and before I choose "delete", the track ends and the next one starts playing. If I then click on "delete" this won't delete my chosen track but the one now playing. Also in the dialog which asks for confirmation there is no hint which track will be deleted. Maybe you could - in a first step - include the track name there.
Confirming - the selection is changed between the time you initiate the action and when it's actually run.
Created attachment 186921 [details] [review] Prevents Banshee from changing the track selection until context menu is closed I'm not sure if this could be cleaned up at all, but it's certainly a simply way of fixing the problem. I added a conditional inside the UpdateSelection function that checks to see if the track context menu is visible. If it is, the selection stays put.
Created attachment 186922 [details] [review] This is the patch I meant to upload Sorry about that. Meant to upload this one instead.
Created attachment 186923 [details] [review] Check if track context menu is open before letting Banshee change track selection That's twice now. Here's the correct patch.
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.