After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620941 - Untranslatable string
Untranslatable string
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
: 619636 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-08 09:29 UTC by Gabor Kelemen
Modified: 2010-06-08 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix order of arguments for translation. (1.60 KB, patch)
2010-06-08 09:33 UTC, Ruben Vermeersch
committed Details | Review

Description Gabor Kelemen 2010-06-08 09:29:30 UTC
There is a serious problem with this string:

#: ../src/PhotoVersionCommands.cs:196
#, csharp-format
msgid "Really reparent \"{2}\" as version of \"{1}\"?"
msgid_plural "Really reparent {0} photos as versions of \"{1}\"?"

This can not be translated, because the singular form contains the {2} variable instead of {1}. gettext gives an error if I translate it, for example:

$ grep -A5 PhotoVersionCommands.cs:196 po/hu.po 
#: ../src/PhotoVersionCommands.cs:196
#, csharp-format
msgid "Really reparent \"{2}\" as version of \"{1}\"?"
msgid_plural "Really reparent {0} photos as versions of \"{1}\"?"
msgstr[0] "Really reparent \"{2}\" as version of \"{1}\"?"
msgstr[1] "Really reparent {0} photos as versions of \"{1}\"?"

$ msgfmt -cv po/hu.po 
po/hu.po:2784: number of format specifications in 'msgid' and 'msgstr[0]' does not match
msgfmt: found 1 fatal error

And because Gnome's git is clever, it does not allow us to commit "faulty" po files.

Please change the code to inlcude {0} in the singular message.
Comment 1 Ruben Vermeersch 2010-06-08 09:33:41 UTC
Created attachment 163031 [details] [review]
Fix order of arguments for translation.
Comment 2 Ruben Vermeersch 2010-06-08 09:34:42 UTC
Attachment 163031 [details] pushed as 2302277 - Fix order of arguments for translation.


Should be fixed, but please check. Thanks for pointing this out!
Comment 3 Ruben Vermeersch 2010-06-08 09:36:03 UTC
*** Bug 619636 has been marked as a duplicate of this bug. ***