After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620910 - Pixbuf save option strings as utf8
Pixbuf save option strings as utf8
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Gtk2
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-07 22:09 UTC by Kevin Ryde
Modified: 2010-12-07 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch and test case (3.25 KB, patch)
2010-06-07 22:09 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-06-07 22:09:30 UTC 
Created attachment 162981 [details] [review]
patch and test case

I believe gdk_pixbuf_savev() expects utf8 for option value strings in PNG format tEXt::Foo options.  The gdk_pixbuf_save() wrapper could helpfully upgrade inputs the same as done in other places taking utf8.

Patch and test case attached.  The docs of gdk_pixbuf_save() describe the value strings as utf8, though the function prototype is "char**" instead of "gchar**".  PNG allows non-ascii in keys too, though it seems gtk presently demands ascii-only.
Comment 1 Torsten Schoenfeld 2010-12-07 21:29:15 UTC 
I tweaked a few things (mainly: SvGChar) and committed.  Thanks!