After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620903 - some messages get dropped when using adium themes
some messages get dropped when using adium themes
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat themes
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
: 621481 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-06-07 20:48 UTC by Ken VanDine
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/adium-620903 (3.86 KB, patch)
2010-06-08 15:45 UTC, Guillaume Desmottes
committed Details | Review

Description Ken VanDine 2010-06-07 20:48:15 UTC
Some clients send \r\n for newlines in a chat message, for example MSN Messenger.  Empathy replaces \n with a <br />, messages with a \r\n just aren't displayed.  They do go in the log and are also displayed properly when using non-adium themes.  

Downstream bug:

https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/546338
Comment 1 Guillaume Desmottes 2010-06-08 08:57:21 UTC
Outch, that's a nasty bug. :\
Comment 2 Guillaume Desmottes 2010-06-08 12:28:46 UTC
Humm, I tried sending 'this is\r\na bug' over XMPP and it's properly displayed. I'd be interested seeing butterfly logs (and maybe even dbus-monitor ones to see exactly what's received by Empathy).
Comment 3 Guillaume Desmottes 2010-06-08 13:20:37 UTC
Ok nevermind, I can reproduce it using amsn.
Comment 4 Guillaume Desmottes 2010-06-08 15:17:33 UTC
Note that this issue shouldn't appear anymore with telepathy-butterfly 0.5.11.

I keep this bug open because Empathy should deal better with this problem anyway.
Comment 5 Guillaume Desmottes 2010-06-08 15:45:41 UTC
Created attachment 163074 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/adium-620903

 libempathy-gtk/empathy-string-parser.c |   16 +++++++++++++-
 tests/empathy-parser-test.c            |   35 +++++++++++---------------------
 2 files changed, 27 insertions(+), 24 deletions(-)
Comment 6 Guillaume Desmottes 2010-06-08 15:48:31 UTC
Comment on attachment 163074 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/adium-620903

Merged to master. I keep the bug opened because I'd like to backport the fix to 2.30 if possible.
Comment 7 Guillaume Desmottes 2010-06-08 15:56:57 UTC
Merged to 2.30 as well. I'll make a 2.30.x release tomorrow.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 8 Guillaume Desmottes 2010-06-15 17:31:36 UTC
*** Bug 621481 has been marked as a duplicate of this bug. ***