GNOME Bugzilla – Bug 620855
[ShellWindowTracker] Don't try to track remote windows
Last modified: 2010-06-07 20:38:45 UTC
Previously we were trying to match up remote windows with local .desktop files, which is definitely wrong. This patch just makes things differently broken, but it's a step towards correctness. The right way to handle this needs design; we could create a fake application for each host, or each (host, app) pair, though the latter would require some way to do app matching on a remote host.
Created attachment 162947 [details] [review] [ShellWindowTracker] Don't try to track remote windows
(In reply to comment #0) > Previously we were trying to match up remote windows with local > .desktop files, which is definitely wrong. This patch just > makes things differently broken, but it's a step towards > correctness. Hmm... I am not sure that the immediate step which basically make the situation worse does any us any good. > The right way to handle this needs design; we could create > a fake application for each host, or each (host, app) pair, > though the latter would require some way to do app matching > on a remote host. Shouldn't we wait until we have a proper design before doing this or is there a specific issue you met where the current remove <-> local .desktop mapping caused issues?
(In reply to comment #2) > > Shouldn't we wait until we have a proper design before doing this or is there a > specific issue you met where the current remove <-> local .desktop mapping > caused issues? For a different patch, I'm going to be using meta_window_get_pid, and I'm trying to prepare the code so that I'm only using that for local windows.
(In reply to comment #3) > (In reply to comment #2) > > > > Shouldn't we wait until we have a proper design before doing this or is there a > > specific issue you met where the current remove <-> local .desktop mapping > > caused issues? > > For a different patch, I'm going to be using meta_window_get_pid, and I'm > trying to prepare the code so that I'm only using that for local windows. OK, we should probably open a different bug to get the design issues solved and to not loose track of it.
Review of attachment 162947 [details] [review]: Looks good, the style cleanup here has nothing to do with the actual change but meh ..
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > > > > Shouldn't we wait until we have a proper design before doing this or is there a > > > specific issue you met where the current remove <-> local .desktop mapping > > > caused issues? > > > > For a different patch, I'm going to be using meta_window_get_pid, and I'm > > trying to prepare the code so that I'm only using that for local windows. > > OK, we should probably open a different bug to get the design issues solved and > to not loose track of it. Filed https://bugzilla.gnome.org/show_bug.cgi?id=620888 for this.
Created attachment 162966 [details] [review] Don't try to track remote windows Previously we were trying to match up remote windows with local .desktop files, which is definitely wrong. This patch simply falls back to the app-from-window case for this; better handling would need design.
Review of attachment 162966 [details] [review]: This is definitely better and feels less like a regression. (App Well and AppSwitcher don't ignore remote apps).
Attachment 162966 [details] pushed as 8aeadcd - Don't try to track remote windows