After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620844 - [GtkBuilder transition] repair_dialog
[GtkBuilder transition] repair_dialog
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal enhancement
: 0.7.1
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks: f-spot-glade
 
 
Reported: 2010-06-07 14:08 UTC by Ruben Vermeersch
Modified: 2010-06-20 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for migrating repair_dialog to GtkBuilder (8.60 KB, patch)
2010-06-20 04:58 UTC, ademir
committed Details | Review

Description Ruben Vermeersch 2010-06-07 14:08:59 UTC
The repair_dialog needs to be migrated to GtkBuilder.
Comment 1 Ruben Vermeersch 2010-06-07 15:21:44 UTC
Instructions on how to fix this can be found here:
http://f-spot.org/GtkBuilder_Transition

Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
Comment 2 ademir 2010-06-20 04:17:52 UTC
Hi! I'll be working on migrate this dialog to GtkBuilder. Best wishes.
Comment 3 ademir 2010-06-20 04:58:04 UTC
Created attachment 164103 [details] [review]
Patch for migrating repair_dialog to GtkBuilder

I finished migration of repair_dialog to GtkBuilder, but don't know if it already been deprecated by using repair_db_dialog.
Comment 4 Ruben Vermeersch 2010-06-20 16:57:12 UTC
You're right, it might be obsolete.

Nonetheless, good and clean patch. Two comments:

* You need to set up git correctly, so that it records your name and contact details. More about this can be found here: http://live.gnome.org/Git/Developers#Setting_up_Git

* Keep your commit messages useful, these last forever. The first line is usually a short description of the commit.

I corrected these two and merged this patch, so you're now an official F-Spot contributor, congratulations!

commit 7f9f32b3291895efad58b8c22954535b0efb40f1
Author: Ademir Mendoza <ademir.mendoza@gmail.com>
Date:   Sat Jun 19 23:52:22 2010 -0500

    Migrate repair_dialog to GtkBuilder.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=620844
Comment 5 ademir 2010-06-20 22:32:43 UTC
Hi! Thanks for your suggestions. I'll be setting it up. Best wishes.