GNOME Bugzilla – Bug 620842
[GtkBuilder transition] last_import_rolls_filter
Last modified: 2010-06-25 08:34:37 UTC
The last_import_rolls_filter needs to be migrated to GtkBuilder.
Instructions on how to fix this can be found here: http://f-spot.org/GtkBuilder_Transition Please indicate below if you are working on this (and if you stopped working on it), so we can avoid duplicate work. If you are stuck, just ask for help on IRC or the mailing list.
Created attachment 164254 [details] [review] Migrates LastImportRollFilterDialog to GtkBuilder
Review of attachment 164254 [details] [review]: potfiles.in please! :)
Created attachment 164367 [details] [review] Added LastImportRollFilterDialog.ui to POTFILES.in Thanks for your review, Maxxer :). Didn't know of that file before. And as it turned out, you adjusted the potfiles.in for my CreateTagDialog-patch. So how could I have known of it ;) Now I know. Is it correct that the potfiles.in still lists those files as glade files?
It seems like that first patch doesn't work anymore, since other patches already landed in master. I must first find out how I can fix this the easiest way with git and then I'll provide new patches.
(In reply to comment #4) > Thanks for your review, Maxxer :). Didn't know of that file before. And as it I thought I told you in another bug, but maybe wasn't you then! thanks for the update. you will probably find info on how to update your patch at https://bugzilla.gnome.org/show_bug.cgi?id=620838
(In reply to comment #4) > Is it correct that the potfiles.in still lists those files as glade files? Yes, it's mainly used to specify how intltool will parse them. The format of Glade and GtkBuilder isn't that different, so the same parser can be used.
Comment on attachment 164367 [details] [review] Added LastImportRollFilterDialog.ui to POTFILES.in Please rebase this together with the other patch :-)
Created attachment 164549 [details] [review] Migrates LastImportRollFilterDialog to GtkBuilder
Created attachment 164550 [details] [review] Added LastImportRollFilterDialog.ui to POTFILES.in
I rebased both patches. Now it should be possible to apply them.
Attachment 164550 [details] pushed as e5337f1 - Added LastImportRollFilterDialog.ui to POTFILES.in Great work, both patches (which are clean and good) applied cleanly and I've pushed them to master. Thanks a lot!