After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620608 - 'add tag' context menu item too slow. totally kills workflow.
'add tag' context menu item too slow. totally kills workflow.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Tags
GIT
Other Linux
: Normal blocker
: 0.7.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on: 322611
Blocks:
 
 
Reported: 2010-06-04 23:46 UTC by Jakub Steiner
Modified: 2010-06-14 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove "Add Tag" menu. (2.57 KB, patch)
2010-06-04 23:54 UTC, Ruben Vermeersch
committed Details | Review

Description Jakub Steiner 2010-06-04 23:46:03 UTC
When having hundreds of tags, which is easily obtainable, the 'add tag' submenu in the context menu takes more than 10 seconds to load on my beefy desktop PC. This makes the whole menu useless (an I use it to remove or delete photos and add rating) as an unintentional hover over the add tag item means staring at a locked f-spot for seconds. do it up and down and it's more like a minute. As adding tags is achievable with a menu or the type tag interface, I seriously suggest to remove this completely.
Comment 1 Ruben Vermeersch 2010-06-04 23:54:37 UTC
Created attachment 162780 [details] [review]
Remove "Add Tag" menu.
Comment 2 Ruben Vermeersch 2010-06-04 23:55:34 UTC
Attachment 162780 [details] pushed as ebd3f36 - Remove "Add Tag" menu.


Now you see it, now you don't! Done!
Comment 3 Ruben Vermeersch 2010-06-06 13:43:55 UTC
From gitorious:
> Guys, very bad idea, IMO!
> This was the only way of tagging in a full screen mode.
> Maybe a better idea was to cache something? It shouldn’t
> take 10 secs to populate a menu of hundreds of tags…
> 
> Anton Keks
Comment 4 Jakub Steiner 2010-06-06 15:24:04 UTC
Well to be honest it was the only way to add tags in fullscreen mode with only a few tags available. Can we perhaps enable the 'T' tagging in fullscreen? I agree making this fast would be a solution, but it's not a trivial fix.
Comment 5 Maxxer 2010-06-06 19:38:55 UTC
(In reply to comment #4)
> Can we perhaps enable the 'T' tagging in fullscreen? I
> agree making this fast would be a solution, but it's not a trivial fix.

there's a request for that: bug 322611.

I agree that right click tagging with a huge tree is almost impossible.
Comment 6 Ruben Vermeersch 2010-06-07 09:43:01 UTC
Okay, we need a solution here. How hard would it be to add tag-to-type to fullscreen? A really long tree of tags is indeed unusable.

As far as I know, the tag entry box is fairly self-contained, so it should be rather doable, but I could be wrong.

Blocker for 0.7.0.
Comment 7 Ruben Vermeersch 2010-06-14 20:34:44 UTC
Closing this bug (as it is fixed). Right way forward seems to add fullscreen type tagging. Info about this is in bug 322611.