GNOME Bugzilla – Bug 620583
add override for TextBuffer
Last modified: 2010-06-22 19:27:28 UTC
* TextBuffer.create_tag takes vargs which we can't bind yet so change it to except a keyword list of properties * override the insert* methods so the developer does not have to enter a length - lengths are already encapsulated by a string in Python
Created attachment 162764 [details] [review] add override for TextBuffer
Review of attachment 162764 [details] [review]: Doesn't apply, looks like some of the changes are missing from the patch.
Created attachment 164227 [details] [review] add override for TextBuffer * TextBuffer.create_tag takes vargs which we can't bind yet so change it to except a keyword list of properties * override the insert* methods so the developer does not have to enter a length - lengths are already encapsulated by a string in Python
Created attachment 164320 [details] [review] add override for TextBuffer * TextBuffer.create_tag takes vargs which we can't bind yet so change it to except a keyword list of properties * override the insert* methods so the developer does not have to enter a length - lengths are already encapsulated by a string in Python
Review of attachment 164320 [details] [review]: A small nitpick in the test, apart from that the patch looks good to me ::: tests/test_overrides.py @@ +157,3 @@ + start = Gtk.TextIter() + end = Gtk.TextIter() + Is this needed? We recently changed the annotations and there should be no need to instanciate the iters
Woops, no that is left over, I'll remove it when committing