After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620583 - add override for TextBuffer
add override for TextBuffer
Status: RESOLVED FIXED
Product: pygi
Classification: Deprecated
Component: general
unspecified
Other All
: Normal normal
: 0.6
Assigned To: pygi-maint
pygi-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-04 17:12 UTC by johnp
Modified: 2010-06-22 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add override for TextBuffer (3.25 KB, patch)
2010-06-04 17:12 UTC, johnp
needs-work Details | Review
add override for TextBuffer (3.75 KB, patch)
2010-06-21 15:55 UTC, johnp
none Details | Review
add override for TextBuffer (3.81 KB, patch)
2010-06-22 16:14 UTC, johnp
none Details | Review

Description johnp 2010-06-04 17:12:47 UTC
* TextBuffer.create_tag takes vargs which we can't bind yet so change it
  to except a keyword list of properties
* override the insert* methods so the developer does not have to enter a length   - lengths are already encapsulated by a string in Python
Comment 1 johnp 2010-06-04 17:12:49 UTC
Created attachment 162764 [details] [review]
add override for TextBuffer
Comment 2 Tomeu Vizoso 2010-06-15 10:10:05 UTC
Review of attachment 162764 [details] [review]:

Doesn't apply, looks like some of the changes are missing from the patch.
Comment 3 johnp 2010-06-21 15:55:11 UTC
Created attachment 164227 [details] [review]
add override for TextBuffer

* TextBuffer.create_tag takes vargs which we can't bind yet so change it
  to except a keyword list of properties
* override the insert* methods so the developer does not have to enter a length
  - lengths are already encapsulated by a string in Python
Comment 4 johnp 2010-06-22 16:14:00 UTC
Created attachment 164320 [details] [review]
add override for TextBuffer

* TextBuffer.create_tag takes vargs which we can't bind yet so change it
  to except a keyword list of properties
* override the insert* methods so the developer does not have to enter a length
  - lengths are already encapsulated by a string in Python
Comment 5 Paolo Borelli 2010-06-22 16:25:40 UTC
Review of attachment 164320 [details] [review]:

A small nitpick in the test, apart from that the patch looks good to me

::: tests/test_overrides.py
@@ +157,3 @@
+        start = Gtk.TextIter()
+        end = Gtk.TextIter()
+

Is this needed? We recently changed the annotations and there should be no need to instanciate the iters
Comment 6 Paolo Borelli 2010-06-22 16:28:22 UTC
Review of attachment 164320 [details] [review]:

A small nitpick in the test, apart from that the patch looks good to me

::: tests/test_overrides.py
@@ +157,3 @@
+        start = Gtk.TextIter()
+        end = Gtk.TextIter()
+

Is this needed? We recently changed the annotations and there should be no need to instanciate the iters
Comment 7 johnp 2010-06-22 19:20:47 UTC
Woops, no that is left over, I'll remove it when committing