After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620536 - Annotate all custom GIO GSource using g_source_set_name
Annotate all custom GIO GSource using g_source_set_name
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2010-06-04 03:49 UTC by Colin Walters
Modified: 2010-07-11 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Annotate all custom GIO GSource using g_source_set_name (3.40 KB, patch)
2010-06-04 03:49 UTC, Colin Walters 		none Details | Review

Description Colin Walters 2010-06-04 03:49:10 UTC 
Naming the sources allows easier debugging with e.g. SystemTap
probes.
Comment 1 Colin Walters 2010-06-04 03:49:12 UTC 
Created attachment 162719 [details] [review]
Annotate all custom GIO GSource using g_source_set_name
Comment 2 Matthias Clasen 2010-06-06 18:10:33 UTC 
Review of attachment 162719 [details] [review]:

::: gio/gsocket.c
@@ +2406,1 @@
   socket_source = (GSocketSource *)source;

Shouldn't the name include a reference to the socket, so that you can discriminate different socktes ? Something like
"GSocket %p", socket ?
Comment 3 Matthias Clasen 2010-07-10 06:09:18 UTC 
Colin, did you want to commit this ?