After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620511 - Use g_source_set_name for all custom GSources in GTK+
Use g_source_set_name for all custom GSources in GTK+
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-03 20:43 UTC by Colin Walters
Modified: 2010-06-04 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use g_source_set_name for all custom GSources in GTK+ (2.91 KB, patch)
2010-06-03 20:43 UTC, Colin Walters
accepted-commit_now Details | Review
g_source_set_name on custom sources (1.54 KB, patch)
2010-06-04 14:32 UTC, Colin Walters
none Details | Review

Description Colin Walters 2010-06-03 20:43:08 UTC
Naming the sources allows easier debugging with e.g. SystemTap
probes.
Comment 1 Colin Walters 2010-06-03 20:43:10 UTC
Created attachment 162690 [details] [review]
Use g_source_set_name for all custom GSources in GTK+
Comment 2 Matthias Clasen 2010-06-03 21:13:14 UTC
Comment on attachment 162690 [details] [review]
Use g_source_set_name for all custom GSources in GTK+

Makes sense to me. Do we need to bump the glib dep for this ?
Comment 3 Colin Walters 2010-06-04 01:51:33 UTC
Committed (and the glib dep bumped)
Comment 4 Colin Walters 2010-06-04 14:32:41 UTC
Created attachment 162757 [details] [review]
g_source_set_name on custom sources

Fixed to use GLIB_CHECK_VERSION