After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620474 - Status reported by account dialog is wrong in connman mode
Status reported by account dialog is wrong in connman mode
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-03 13:03 UTC by Rob Bradford
Modified: 2010-06-03 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix problem (2.57 KB, patch)
2010-06-03 13:05 UTC, Rob Bradford
accepted-commit_now Details | Review

Description Rob Bradford 2010-06-03 13:03:00 UTC
When empathy is built with connman the account status shown in the accounts dialog is sometimes incorrect.

Whenever the account is in state DISCONNECTED the error is always was reported as a connection problem. This was because the EmpathyConnectivity object was too short lived to get a response to the asynchronous call that it makes to find out if it was online or not (the NM mode makes a synchronous call.)

The incoming patch simply associates with the connectivity object to the dialog so that there is time for the initial request to be made and responded to.
Comment 1 Rob Bradford 2010-06-03 13:05:52 UTC
Created attachment 162647 [details] [review]
Patch to fix problem
Comment 2 Guillaume Desmottes 2010-06-03 13:25:03 UTC
Review of attachment 162647 [details] [review]:

Looks good. Please merge to 2.30 and master.
Comment 3 Rob Bradford 2010-06-03 13:55:38 UTC
All merged thanks!