After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620378 - [overview] Fix dnd on mulit screen setups
[overview] Fix dnd on mulit screen setups
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-02 16:58 UTC by drago01
Modified: 2010-06-03 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[overview] Fix dnd on mulit screen setups (3.01 KB, patch)
2010-06-02 16:58 UTC, drago01 		committed Details | Review

Description drago01 2010-06-02 16:58:08 UTC 
See patch.
Comment 1 drago01 2010-06-02 16:58:30 UTC 
Created attachment 162557 [details] [review]
[overview] Fix dnd on mulit screen setups

Currently we don't get any drop events for dual screen modes with a screen
at the right, and behave weird by hardcoding the screen size and 0 as drag
edges.

Fix that by spawning the drop group over the whole stage and take the primary monitors position and size into account in _handleDragOver.
Comment 2 Florian Müllner 2010-06-02 17:10:30 UTC 
Review of attachment 162557 [details] [review]:

I can only look at the code which looks reasonable(*). I'd say: commit if it works for ebassi ;)


(*) long term I think we want to get rid of _dropGroup altogether
Comment 3 Emmanuele Bassi (:ebassi) 2010-06-03 09:33:56 UTC 
I can confirm that DnD is now fixed on my dual-screen set up with this patch applied. thanks!
Comment 4 drago01 2010-06-03 09:36:56 UTC 
Attachment 162557 [details] pushed as fe91f7f - [overview] Fix dnd on mulit screen setups