After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620374 - Change user menu "available" and "busy" icons so colorblind people can tell the difference
Change user menu "available" and "busy" icons so colorblind people can tell t...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-06-02 16:42 UTC by Jens Knutson
Modified: 2010-06-11 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[statusMenu] Use user status icons from icon theme (2.73 KB, patch)
2010-06-08 13:34 UTC, Florian Müllner
none Details | Review
[statusMenu] Use user status icons from icon theme (2.75 KB, patch)
2010-06-10 23:39 UTC, Florian Müllner
committed Details | Review

Description Jens Knutson 2010-06-02 16:42:04 UTC
Currently the "Available" and "Busy" indicator icons in the user menu are a green dot and a red dot, respectively.

The most common variety of color blindness is red-green, so this is a problem for a number of people (including myself).  Changing the shape of the icon would help a lot (actually, it would *solve* the issue as far as I'm concerned, but I don't know about more formal a11y requirements.).

Maybe just use Empathy's status icons?  They all use a distinct color AND shape for each status type.
Comment 1 Dan Winship 2010-06-08 12:45:29 UTC
the current icons were picked to match the mockups and... well:

        // FIXME: these icons are all wrong (likewise in createSubMenu)
        this._availableIcon = textureCache.load_icon_name('gtk-yes', 16);
        this._busyIcon = textureCache.load_icon_name('gtk-no', 16);
        this._invisibleIcon = textureCache.load_icon_name('gtk-close', 16);
        this._idleIcon = textureCache.load_icon_name('gtk-media-pause', 16);

presumably there should be some set of theme icons we can use. If we don't like the appearance of the "correct" theme icons then we can fix the default icon theme.
Comment 2 Florian Müllner 2010-06-08 13:34:32 UTC
Created attachment 163057 [details] [review]
[statusMenu] Use user status icons from icon theme

Currently, we use 'gtk-yes', 'gtk-no' and 'gtk-media-pause' as
user status icons. It seems more logical to use the dedicated
icons from gnome-icon-theme instead.

Note that if we decide that this is the way to go, I'd fully expect Jon to file a bug against gnome-icon-theme to replace the current icons, which are plain awful (user-available should be called user-alive, user-busy is indeed very busy, and "best": a friggin' ghost?!)
Comment 3 Guillaume Desmottes 2010-06-08 14:20:52 UTC
Note that Empathy 2.31.x is now using status icon from gnome-icon-theme (using the standard fdo naming) so it would make sense to do the same in the shell.
Comment 4 Florian Müllner 2010-06-10 23:39:03 UTC
Created attachment 163351 [details] [review]
[statusMenu] Use user status icons from icon theme

Rebased on master.
Comment 5 Florian Müllner 2010-06-11 12:51:38 UTC
Expect a new bug against gnome-icon-theme soon ;)

Attachment 163351 [details] pushed as e6a70e4 - [statusMenu] Use user status icons from icon theme