After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 620288 - Invalid read of size 1 in soup-date.c
Invalid read of size 1 in soup-date.c
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2010-06-01 17:33 UTC by Xan Lopez
Modified: 2010-06-10 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xan Lopez 2010-06-01 17:33:34 UTC
==18726== Invalid read of size 1
==18726==    at 0x84D9D5D: parse_timezone (soup-date.c:377)
==18726==    by 0x84D974D: parse_textual_date (soup-date.c:415)
==18726==    by 0x84D9EF0: soup_date_new_from_string (soup-date.c:495)
==18726==    by 0x84D53C9: parse_date (soup-cookie.c:204)
==18726==    by 0x84D5737: parse_one_cookie (soup-cookie.c:255)
==18726==    by 0x84D6146: soup_cookies_from_response (soup-cookie.c:876)
==18726==    by 0x84D79D1: process_set_cookie_header (soup-cookie-jar.c:562)
==18726==    by 0xF6D222E: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==18726==    by 0x84E08CC: header_handler_metamarshal (soup-message.c:1082)
==18726==    by 0xF6B6F5C: g_closure_invoke (gclosure.c:767)
==18726==    by 0xF6D15C6: signal_emit_unlocked_R (gsignal.c:3243)
==18726==    by 0xF6D0259: g_signal_emit_valist (gsignal.c:2976)
==18726==    by 0xF6D0868: g_signal_emit (gsignal.c:3033)
==18726==    by 0x84E0627: soup_message_got_headers (soup-message.c:954)
==18726==    by 0x84E66BE: io_read (soup-message-io.c:902)
==18726==    by 0xF6D222E: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==18726==    by 0xF6B6F5C: g_closure_invoke (gclosure.c:767)
==18726==    by 0xF6D15C6: signal_emit_unlocked_R (gsignal.c:3243)
==18726==    by 0xF6D0259: g_signal_emit_valist (gsignal.c:2976)
==18726==    by 0xF6D0868: g_signal_emit (gsignal.c:3033)
==18726==    by 0x84F42AF: socket_read_watch (soup-socket.c:1245)
==18726==    by 0xFFB0561: g_io_unix_dispatch (giounix.c:162)
==18726==    by 0xFF64E34: g_main_dispatch (gmain.c:1960)
==18726==    by 0xFF66633: g_main_context_dispatch (gmain.c:2513)
==18726==    by 0xFF66C1C: g_main_context_iterate (gmain.c:2591)
==18726==    by 0xFF67472: g_main_loop_run (gmain.c:2799)
==18726==    by 0xB7745DB: gtk_main (gtkmain.c:1219)
==18726==    by 0x402512: main (main.c:209)
==18726==  Address 0x171255e9 is 0 bytes after a block of size 25 alloc'd
==18726==    at 0x4C221A7: malloc (vg_replace_malloc.c:195)
==18726==    by 0xFF6E816: g_malloc (gmem.c:131)
==18726==    by 0xFF8A943: g_strndup (gstrfuncs.c:155)
==18726==    by 0x84D5302: parse_value (soup-cookie.c:191)
==18726==    by 0x84D53BC: parse_date (soup-cookie.c:203)
==18726==    by 0x84D5737: parse_one_cookie (soup-cookie.c:255)
==18726==    by 0x84D6146: soup_cookies_from_response (soup-cookie.c:876)
==18726==    by 0x84D79D1: process_set_cookie_header (soup-cookie-jar.c:562)
==18726==    by 0xF6D222E: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==18726==    by 0x84E08CC: header_handler_metamarshal (soup-message.c:1082)
==18726==    by 0xF6B6F5C: g_closure_invoke (gclosure.c:767)
==18726==    by 0xF6D15C6: signal_emit_unlocked_R (gsignal.c:3243)
==18726==    by 0xF6D0259: g_signal_emit_valist (gsignal.c:2976)
==18726==    by 0xF6D0868: g_signal_emit (gsignal.c:3033)
==18726==    by 0x84E0627: soup_message_got_headers (soup-message.c:954)
==18726==    by 0x84E66BE: io_read (soup-message-io.c:902)
==18726==    by 0xF6D222E: g_cclosure_marshal_VOID__VOID (gmarshal.c:77)
==18726==    by 0xF6B6F5C: g_closure_invoke (gclosure.c:767)
==18726==    by 0xF6D15C6: signal_emit_unlocked_R (gsignal.c:3243)
==18726==    by 0xF6D0259: g_signal_emit_valist (gsignal.c:2976)
==18726==    by 0xF6D0868: g_signal_emit (gsignal.c:3033)
==18726==    by 0x84F42AF: socket_read_watch (soup-socket.c:1245)
==18726==    by 0xFFB0561: g_io_unix_dispatch (giounix.c:162)
==18726==    by 0xFF64E34: g_main_dispatch (gmain.c:1960)
==18726==    by 0xFF66633: g_main_context_dispatch (gmain.c:2513)
==18726==    by 0xFF66C1C: g_main_context_iterate (gmain.c:2591)
==18726==    by 0xFF67472: g_main_loop_run (gmain.c:2799)
==18726==    by 0xB7745DB: gtk_main (gtkmain.c:1219)
==18726==    by 0x402512: main (main.c:209)
Comment 1 Dan Winship 2010-06-10 00:11:53 UTC
fixed, and fixed the date-parsing test to catch this sort of bug. thanks.